After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 308475 - potentially incorrect activation_uri when drive is mounted from file chooser
potentially incorrect activation_uri when drive is mounted from file chooser
Status: RESOLVED FIXED
Product: libgnomeui
Classification: Deprecated
Component: file-chooser
CVS HEAD
Other Linux
: Normal normal
: future
Assigned To: Alexander Larsson
Alexander Larsson
Depends on:
Blocks:
 
 
Reported: 2005-06-21 02:05 UTC by David Zeuthen (not reading bugmail)
Modified: 2005-06-21 14:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.73 KB, patch)
2005-06-21 02:06 UTC, David Zeuthen (not reading bugmail) 		accepted-commit_now Details | Review

Description David Zeuthen (not reading bugmail) 2005-06-21 02:05:35 UTC 
Distribution/Version: Fedora

The gnome-vfs backend for the GTK file chooser (incorrectly) makes the
assumption that the activation_uri for the GnomeVFSVolume that is the result of
a mount within the file chooser will be the same as for the GnomeVFSDrive that
it stems from. 

In fact, the activation_uri for the GnomeVFSDrive is, at best, a guess since it
is derived from e.g. /etc/fstab and the user may use a different mount program
(e.g. pmount) that mounts the file system in another location which may be
unknown (and private to e.g. pmount) at GnomeVFSDrive creation time. Ideally,
we'd remove activation_uri from GnomeVFSDrive (since it makes little sense qua
the above explanation) but I suppose we cannot break API/ABI in gnome-vfs :-/.

One simple solution is to check whether the GnomeVFSDrive has got a
corresponding GnomeVFSVolume and use the activation_uri from this. Will attach
patch that does exactly this. This patch works for me but I'm unsure this is the
best approach. I've copied alexl on this bug for comments as well.
Comment 1 David Zeuthen (not reading bugmail) 2005-06-21 02:06:57 UTC 
Created attachment 48076 [details] [review]
proposed patch

Please review. Thanks.
Comment 2 Alexander Larsson 2005-06-21 06:54:13 UTC 
looks good to me.
Comment 3 Kjartan Maraas 2005-06-21 11:02:44 UTC 
Marking as accepted-commit_now based on the last comment.
Comment 4 David Zeuthen (not reading bugmail) 2005-06-21 14:53:38 UTC 
Patch is now committed to CVS. Thanks.