After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 308335 - [PATCH] ffmpeg postprocessing plugins
[PATCH] ffmpeg postprocessing plugins
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal enhancement
: 0.8.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2005-06-19 21:44 UTC by Edward Hervey
Modified: 2005-06-20 16:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch for postproc requirements (984 bytes, patch)
2005-06-19 21:44 UTC, Edward Hervey
accepted-commit_now Details | Review
the ext/postproc directory tarball (5.28 KB, application/x-compressed-tar)
2005-06-19 21:45 UTC, Edward Hervey
previous tarball as a patch (17.52 KB, patch)
2005-06-19 21:49 UTC, Edward Hervey
none Details | Review
New version with proper in_place processing (17.11 KB, patch)
2005-06-20 08:54 UTC, Edward Hervey
accepted-commit_now Details | Review

Description Edward Hervey 2005-06-19 21:44:05 UTC
I finally wrapped the libpostproc which is in ffmpeg.

No parameters are available yet, apart from the quality (which is by default at
best quality).
Comment 1 Edward Hervey 2005-06-19 21:44:51 UTC
Created attachment 48019 [details] [review]
patch for postproc requirements
Comment 2 Edward Hervey 2005-06-19 21:45:34 UTC
Created attachment 48020 [details]
the ext/postproc directory tarball
Comment 3 Edward Hervey 2005-06-19 21:49:47 UTC
Created attachment 48021 [details] [review]
previous tarball as a patch
Comment 4 Ronald Bultje 2005-06-20 06:57:08 UTC
So it doesn't actually do anything yet...? :) Approach looks good otherwise, now
make it work and I'll be happy (and you can apply).
Comment 5 Edward Hervey 2005-06-20 08:54:54 UTC
Created attachment 48034 [details] [review]
New version with proper in_place processing
Comment 6 Ronald Bultje 2005-06-20 08:59:22 UTC
+  /*
+    TODO : We need to find out what CPU flags we have in order to set
+    MMX/MMX2/3DNOW optimizations
+  */

That doesn't look good, since it is implemented. Please remove.

+/*   inplane[0] = GST_BUFFER_DATA(in); */
+/*   inplane[1] = inplane[0] + postproc->ysize; */
+/*   inplane[2] = inplane[1] + postproc->usize; */

Since you don't use the inplane, can you remove it?

Apart from those two minor issues, it looks good. Please apply. Please run it
through gst-indent before applying, I'm trying to keep style in the .c files
consistent (and am faling hopelessly :) ).
Comment 7 Edward Hervey 2005-06-20 10:07:22 UTC
ok, removing those comments, indenting it and commiting it
Comment 8 Edward Hervey 2005-06-20 14:10:00 UTC
commited, you may close if needed
Comment 9 Olav Vitters 2005-06-20 15:07:35 UTC
Edward: you fixed it, so why don't you close it? That way if you mark this and
10 other plugins for Gstreamer in the coming week you'll appear at:
Comment 10 Ronald Bultje 2005-06-20 16:03:07 UTC
So I'm gonna be an ass, but I'll reopen and mark as resolved/fixed, since I use
bugs with that status and a target milestone set for the release notes. ;).