GNOME Bugzilla – Bug 308208
Play Album window does not show all albums
Last modified: 2008-09-28 13:54:53 UTC
Please describe the problem: Various albums dont apear in the "play album". I though it was because these albums were incomplete. But in full albums the problems apears too. The problem was the lack of "track number" information. After adding that info with easytag, the album apeared. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
*** Bug 315327 has been marked as a duplicate of this bug. ***
From 315327: "10 songs with the same album in their ID3's will not be counted as an album. 10 songs with the same album in their ID3's AND in a directory with the name of the album will be counted as an album." While mostly true, the directory name does not seem to be an issue. However, the tracks not only need numbering, but the numbering must be sequential. For example, I have a CD where I deleted some tracks because I did not like them at all, so I was left with 1, 3, 4, 6, 7, and 9. This was not considered an album. However, renumbering the files to 1, 2, 3, 4, 5, 6 made Muine recognize it as an album. This behaviour is highly broken, though. I have some single tracks that are just a song, for example track 3 out of 19. *This* is considered an album because of the available tracks (1), all of the files are in sequence. This behaviour is very confusing to users and took a good deal of time to discover. Marking critical because it needs to be considered at the very least.
Hi, This happened to me also: If I have an album which has tracknumbers like 01 instead of 01/21, it won't show up in Muine. If you add the /21 (if the particular album has 21 tracks) it will pop up in muine after a restart. greets, rubin at xs4all dot nl
Is this bug still present?
In the 0.8.4 version in Debian unstable it still appears to be. But it's not clear if it's desired behaviour or not. It might also be somewhere in-between, desired but buggy.
In that case, this should be configurable, like 'show incomplete albums'.
Where is this handled inside the code? I would like to add the option for showing incomplete albums.
Can one of our benevolent dictators share his/her opinion about this issue? Is this WONTFIX or should an option be added?
*** Bug 329011 has been marked as a duplicate of this bug. ***
Created attachment 76542 [details] [review] Re-implements "only_complete_albums" gconf key. Muine's cvs logs say that long ago there was a GConf key to make everyone happy around this bug/feature of incomplete albums. This patch adds that key and its corresponding magic. :)
patch looks good, thanks. Latexer, was this issue decided yet or is this patch ok to commit?
Changing component. Filter "uws doing muine component triaging" to get rid of the spam. Thanks!
I don't see this patch solving the actual problem. It works around it by making the current behaviour official. From what I can see in the patch, unchecking the option for complete albums doesn't actually show me *all* of my albums. The old behaviour was that partial albums were listed in the album list too.
Pat, the patch creates/adds a gconf key that when FALSE will make Muine have the old behavior of incomplete albums (that means ALL). When TRUE it will have the current behavior of showing only complete albums.
Hmmm... alo?
It's up to latexer to decide.
zing
One vote more to add the patch.
*** Bug 491087 has been marked as a duplicate of this bug. ***
Whatever. If Diego and Luis agree, go ahead and commit.
Created attachment 119530 [details] [review] [PATCH] Bug 308208 – Play Album window does not show all albums Revert an old commit removing only_complete_albums functionality. You can now choose wheter muine should or should not show incomplete albums using a gconf key: /apps/muine/only_complete_albums. This is the old-old-really-old behaviour of muine of including every album in the list no matter it is not complete. --- ChangeLog | 15 +++++++++++++++ data/muine.schemas.in | 11 +++++++++++ src/Album.cs | 7 ++++++- src/SongDatabase.cs | 20 ++++++++++++++++++-- 4 files changed, 50 insertions(+), 3 deletions(-)
Committed the updated version.