After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 307884 - [patch] memleak in screen.c
[patch] memleak in screen.c
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
trunk
Other Linux
: High normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2005-06-16 06:47 UTC by Aivars Kalvans
Modified: 2005-07-12 19:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (531 bytes, patch)
2005-06-16 06:49 UTC, Aivars Kalvans 		accepted-commit_now Details | Review

Description Aivars Kalvans 2005-06-16 06:47:38 UTC 
From http://www.gnome.org/~kmaraas/valgrind-logs-2005-06-09/metacity :

==14768== 20 bytes in 1 blocks are definitely lost in loss record 1325 of 2712
==14768==    at 0x1B909222: malloc (vg_replace_malloc.c:130)
==14768==    by 0x1BE76F55: g_malloc (gmem.c:137)
==14768==    by 0x806C672: reload_xinerama_infos (screen.c:343)
==14768==    by 0x806DDB4: meta_screen_new (screen.c:581)
==14768==    by 0x805B9B4: meta_display_open (display.c:664)
==14768==    by 0x80667E4: main (main.c:470)
Comment 1 Aivars Kalvans 2005-06-16 06:49:09 UTC 
Created attachment 47850 [details] [review]
proposed patch

Releases ->xinerama_infos
Comment 2 Elijah Newren 2005-07-12 17:08:58 UTC 
Hmm...I had noticed the leak at some point before and even wrote it down, but
apparently forgot about it.  Thanks for catching it and writing the patch.  I
think this qualifies as an obvious patch that I'm allowed to accept (Havoc, kick
me if I'm wrong), so go ahead and commit to the gnome-2-10 branch and HEAD (let
me know if you don't have CVS access and I'll commit it for you).
Comment 3 Aivars Kalvans 2005-07-12 19:09:32 UTC 
        * src/screen.c (meta_screen_free): free ->xinerama_infos
        Closes bug#307884