After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 307535 - Merge C and script-fu Unsharp Masks
Merge C and script-fu Unsharp Masks
Status: RESOLVED WONTFIX
Product: GIMP
Classification: Other
Component: Plugins
git master
Other Linux
: Normal normal
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks: 116145
 
 
Reported: 2005-06-13 16:57 UTC by Akkana Peck
Modified: 2005-06-17 11:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Akkana Peck 2005-06-13 16:57:36 UTC 
GIMP has two built-in Unsharp Mask routines: one in C, one in Script-fu, both
called "Unsharp Mask". The algorithms seem to be different, and they have
different numbers of parameters. Sven wants them merged into one and asked in
bug 116145 that I file a bug on this.
Comment 1 Sven Neumann 2005-06-14 10:31:37 UTC 
Is there really anything to merge here? I haven't looked at it in detail but I
think we can just remove the Script-Fu version without loosing any
functionality. Is that assumption not correct?
Comment 2 Michael Schumacher 2005-06-15 11:18:58 UTC 
IMO the script can just be removed. If it is used by something, we should try to
find values that achieve identical results with the C version. I tried it a few
times and got pretty close, so the algorithms seem to be basically the same.
Comment 3 Sven Neumann 2005-06-16 13:39:14 UTC 
Probably the only advantage that the script version has is that it leaves you
with a layer so that you can adjust the sharpness by changing it's opacity. But
I don't think that this is of general usefulness.
Comment 4 Sven Neumann 2005-06-17 11:04:09 UTC 
I've removed the script from the menus. Perhaps it should be removed completely
at some point...

2005-06-17  Sven Neumann  <sven@gimp.org>

	* plug-ins/script-fu/scripts/unsharp-mask.scm: removed menu
	registration (bug #307535).

Closing this report as WONTFIX because we didn't merge the two.