After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 307513 - (ab-cmdline) Please update some of the commandline tools.
(ab-cmdline)
Please update some of the commandline tools.
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.4.x (obsolete)
Other Linux
: High blocker
: ---
Assigned To: Devashish Sharma
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2005-06-13 14:30 UTC by Ali Akcaagac
Modified: 2013-09-10 14:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch that fixes Path issues for 2.3.x version of Evolutions. (687 bytes, patch)
2005-06-14 12:43 UTC, Ali Akcaagac
committed Details | Review

Description Ali Akcaagac 2005-06-13 14:30:24 UTC
Those tools seem to still be searching in ~/evolution/local/Contacts rather than
following the heavily refactoring of dirstructures that happened quite some time
ago. Would be nice if these tools could be updated.

evolution-addressbook-clean
evolution-addressbook-export

CVS Bugreport.
Comment 1 André Klapper 2005-06-14 09:21:42 UTC
evolution-addressbook-export works here with evolution-2.2.3 (vcard output), 
it's still partly broken (bug 269870) but it *definitely* searches for contacts 
in the right place.
which evolution version do you use? where is "evolution-addressbook-*" located 
on your system? which distro?
how does it come that you think it's still searching in the old directory? which 
errors do you get on the commandline?
please submit more information.
Comment 2 Ali Akcaagac 2005-06-14 12:42:59 UTC
It don't here. I am using Evolution 2.3.3 from CVS to be honest. And I think you
also know that evolution changed the filestructure quite a bit for the homedir.

You recall the days when evolution has put the files in

$(HOME)/evolution/...

The stuff now (well for probably one year at least) is now being stored in

$(HOME)/.evolution/...

And the internal filestructure got changed too. So initially the contacts used
to be in

${HOME}/evolution/local/Contacts/addressbook.db

But after the big filestructure change it's now in

${HOME}/.evolution/addressbook/local/system/addressbook.db

So I wonder how this tool can work out correctly for you but then maybe your
2.2.x version still has the stuff in evolution rather than .evolution. Anyways I
tracked the problem down and found the affecting file that wasn't touched for 2
years now and I am offering a PATCH for this as you can see in the attachment.
Comment 3 Ali Akcaagac 2005-06-14 12:43:35 UTC
Created attachment 47754 [details] [review]
Patch that fixes Path issues for 2.3.x version of Evolutions.
Comment 4 André Klapper 2005-06-14 18:16:06 UTC
for your interest: changing "~/evolution" to "~/.evolution" took place within 
the 1.5 development cycle, so "~/.evolution" is since 2.0.

thanks very much for the patch, that's cool, but please add a changelog and send 
it to evolution-patches mailing list (see
<http://www.gnome.org/projects/evolution/patch.shtml>).

...but you still don't answer my question how it comes that you think it's still 
searching in the old directory, or which errors you get. :-)
Comment 5 André Klapper 2005-07-13 16:43:17 UTC
adding version number and patch keyword
Comment 6 Ali Akcaagac 2005-07-22 20:11:56 UTC
Well, I got this warning when running Evolution through gnome-terminal. While te
address book database get touched (time & date change) it was not sure for me
whether anything happened or not, so I assumed there is something wrong.

galaxy@ulixys:~ > /usr/local/libexec/evolution/2.4/evolution-addressbook-clean

** (evolution:29926): WARNING **: FIXME: wait for completion unimplemented
Shutting down evolution-alarm-notify (Evolution Calendar alarm notification service)
/bin/mv: cannot stat `/home/galaxy/evolution/local/Contacts/addressbook.db': No
such file or directory
Command failed: /bin/mv /home/galaxy/evolution/local/Contacts/addressbook.db
/home/galaxy/evolution/local/Contacts/addressbook-backup.db at
/usr/local/libexec/evolution/2.4/evolution-addressbook-clean line 8.
galaxy@ulixys:~ >
Comment 7 Ali Akcaagac 2005-09-11 18:07:45 UTC
This could already have been committed to Evolution even for the 2.4.0 release.
Any feedback for it ?
Comment 8 André Klapper 2005-09-19 09:14:51 UTC
setting target milestone to 2.5.
Comment 9 Ali Akcaagac 2005-11-06 00:20:50 UTC
Can I expect some progress here ? I really wonder why it takes so many months to
commit a silly 1 liner that clearly solves some bugs ? And why is it retargeted
for the 2.5 milestone ? The issue still exists in 2.4.x and probably earlier
versions as well.
Comment 10 André Klapper 2005-11-06 04:08:47 UTC
hi ali,
thanks again for pointing on this. correct, i can reproduce this here. raising
priority. targetting to 2.4.2 - please note that this does not mean that this
definitely will be included in 2.4.2 release, but that the developers will more
likely take a look on this (sushma?).

in my opinion the patch does not solve the entire problem. it fixes a wrong and
old path, so it should be committed as soon as possible, but it only uses the
primary addressbook and not any potential other addressbooks. no idea how to
solve that, it's more complex, and not your problem. :-)
Comment 11 André Klapper 2005-11-06 04:16:34 UTC
the command also still uses "killev". this can result in data loss (e.g. status
of read mail which becomes unread again).
this should also be fixed by using "evolution --force-shutdown" instead.
Comment 12 André Klapper 2005-12-07 00:42:56 UTC
sush?
Comment 13 André Klapper 2006-01-09 13:48:45 UTC
hi ali,
i have committed this both to HEAD and stable branch, so it will be included in 2.4.3 and 2.5.5:

http://cvs.gnome.org/viewcvs/evolution/addressbook/tools/evolution-addressbook-clean.in?r1=1.2&r2=1.2.50.1
http://cvs.gnome.org/viewcvs/evolution/addressbook/tools/evolution-addressbook-clean.in?r1=1.2&r2=1.3

thanks for your patience. sorry. :-/

so comment #11 remains still valid, therefore i will not close this bug here.
Comment 14 Karsten Bräckelmann 2006-01-14 01:54:37 UTC
Can cause data corruption? Easy fix? BLOCKER.
Comment 15 Christian Neumair 2006-04-03 11:40:12 UTC
Andre, are you going to handle this? :)
Comment 16 André Klapper 2006-04-06 11:51:10 UTC
christian: no, because i don't know c.
Comment 17 Ali Akcaagac 2006-04-14 07:31:01 UTC
> christian: no, because i don't know c.

I can't follow... But what part does require knowledge of C here ? It was just a small Bash script fix...
Comment 18 André Klapper 2006-04-14 12:08:36 UTC
to clarify again: ali, your patch is committed. see comment 13. and see comment 10 why this bug is still open. fixing comment 10 needs c code, since it currently only uses the primary addressbook and not any potential other addressbooks.
Comment 19 André Klapper 2006-05-19 18:31:58 UTC
devashish: *ping*?
retargetting.
Comment 20 André Klapper 2006-06-17 22:47:21 UTC
harmonizing target milestones, sorry for the noise. (2.6.x -> 2.6)
Comment 21 Harish Krishnaswamy 2006-08-10 12:52:22 UTC
Setting Target milestone to 2.8 ==> This is a must fix for this release.
Comment 22 Devashish Sharma 2006-08-11 06:12:52 UTC
This utility is only meant for primary addressbook.
As far as using killev is concerned evolution --force-shutdown uses killev inernally. So i dont think anything needs to be fixed here.