After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 307210 - Autodownload filename annoyments
Autodownload filename annoyments
Status: RESOLVED OBSOLETE
Product: epiphany
Classification: Core
Component: Downloads
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 332126 (view as bug list)
Depends on: 522230
Blocks:
 
 
Reported: 2005-06-10 21:01 UTC by Bastien Nocera
Modified: 2011-05-16 22:57 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Bastien Nocera 2005-06-10 21:01:59 UTC
1. Click on a foo.tar.gz link
2. Choose to open it
3. Click on a foo.tar.gz link (the same name, maybe another link...)
4. File is named foo.tar-1.gz and it confuses the hell out of file-roller.

In embed/mozilla/MozDownload.cpp: BuildDownloadPath
We should check whether the suffix of the file being downloaded is known
(through gnome-vfs, shared-mime-info carries this information), and use that as
the delimiter:
foo.tar.gz has an extension of .tar.gz so the second instance should be called
foo-1.tar.gz
Comment 1 Jean-François Rameau 2005-09-04 21:08:03 UTC
I really can't repro. Epiphany takes care of such compressed extensions since
v1.6 at least (parse_extension and file_is_compressed functions called from
BuildDownloadPath function).

Also, I never see such a name, foo.tar-1.gz, when downloading but foo.tar.1.gz
yes. Is it a typo ?

Can you tell us your version (I see CVS HEAD in the bug report but I doubt :) ).

Jean-François.
Comment 2 Bastien Nocera 2005-09-04 21:51:36 UTC
I verified that the same problem existed in CVS HEAD, but the discussion dates
back from last year, in a private e-mail conversation with Marco and Xan.

Having "foo.tar.1.gz" is just a slightly different name, but the exact same
problem...
Comment 3 Reinout van Schouwen 2006-01-25 22:26:53 UTC
Can you still reproduce this? This bug contradicts bug 171116 (which I can't reproduce either, btw)
Comment 4 Wouter Bolsterlee (uws) 2006-05-13 13:17:11 UTC
Try to open a foo.tar.gz file directly from Epiphany. Close file-roller. Revisit the page and click the link again. Choose "Open" once again. File-roller doesn't know how to handle the new file.
Comment 5 Christian Persch 2006-05-13 14:27:14 UTC
I see the filename being .tar-1.gz but file-roller can still open it here...
I thought we had some code to check for double-extensions, maybe it's broken?
Comment 6 Christian Persch 2007-05-30 11:09:32 UTC
*** Bug 332126 has been marked as a duplicate of this bug. ***
Comment 7 Cosimo Cecchi 2007-12-20 16:07:23 UTC
I can't check with a locale different from italian right now, but both the testcases in this bug and in the duplicate bug #332126 produce foo(1).tar.gz and bar(1).ps.gz, so I think this is obsolete.
Can someone with a different locale test this again?
Comment 8 Bastien Nocera 2008-01-30 13:31:05 UTC
I'm currently using epiphany 2.20.1, with firefox-2.0.0.8-2.fc8, and I still see the problem.

1. Click on http://0pointer.de/lennart/projects/gst-pulse/gst-pulse-0.9.7.tar.gz
2. Choose "Open", file is opened correctly with file-roller
3. Click on http://0pointer.de/lennart/projects/gst-pulse/gst-pulse-0.9.7.tar.gz again
4. Choose "Open", file-roller opens gst-pulse-0.9.7.tar-1.gz, and shows only gst-pulse-0.9.7.tar-1 as the file in the archive
Comment 9 Bastien Nocera 2008-01-30 13:33:07 UTC
Same problem with 2.21.5 and xulrunner as the backend.
Comment 10 Bastien Nocera 2008-01-30 13:34:29 UTC
I use "LC_ALL=en_GB.UTF-8" as my locale (if that makes any difference).
Comment 11 Christian Persch 2008-01-30 14:01:18 UTC
Right I can repro with the steps from comment 8.
Comment 12 Diego Escalante Urrelo (not reading bugmail) 2008-01-30 17:32:09 UTC
Could this be related to ungzipped text still being saved with .gz extension? I mean, the (dot)(something) is being appended separately of the file status. Like appending the -1 to tar and not to gz, and appending gz to something already uncompressed.
Comment 13 Diego Escalante Urrelo (not reading bugmail) 2009-12-14 08:10:11 UTC
Couldn't reproduce with ephy from master, the (1) was put before the .tar.gz. The code there for auto downloads is a bit different, reopen if you hit this again.
Comment 14 Bastien Nocera 2011-05-16 22:57:05 UTC
Yep, works fine here now (called gst-pulse-0.9.7(1).tar.gz)