After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 306775 - [PATCH] EntryView sort-order changes & fixes
[PATCH] EntryView sort-order changes & fixes
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
HEAD
Other Linux
: High normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-06-07 13:14 UTC by James "Doc" Livingston
Modified: 2005-07-07 12:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Does the thing described in the initial description (7.35 KB, patch)
2005-06-08 07:57 UTC, James "Doc" Livingston
none Details | Review

Description James "Doc" Livingston 2005-06-07 13:14:55 UTC
The first of the bug-fix patches from my arch branch. This patch:

a) allows you to do sorting at this level without a key in GConf
b) adds functions to get/set the sorting order as seperate values (as opposed to
the composite GConf string)
c) fixes the long-standing bug (although no-one actually reported it) where you
can't sort the library in descending order if any filer
(artist/album/genre/search) is used

They would probably be better as seperate patches, but they're a bit intertwined
(I could break them up if necessary).
Comment 1 Christian Kirbach 2005-06-07 15:18:18 UTC
Patch : Raising priority and confirming to encourage patch review.
Comment 2 James "Doc" Livingston 2005-06-08 07:57:30 UTC
Created attachment 47415 [details] [review]
Does the thing described in the initial description

Just noticed that I hadn't attached the patch. Oops
Comment 3 Bastien Nocera 2005-07-07 12:57:48 UTC
2005-07-07  Bastien Nocera  <hadess@hadess.net>

        * widgets/rb-entry-view.c: (rb_entry_view_sync_sorting),
        (rb_entry_view_get_sorting_type), (rb_entry_view_set_sorting_type),
        (rb_entry_view_get_sorting_order),
        (rb_entry_view_set_sorting_order),
        (rb_entry_view_column_clicked_cb), (rb_entry_view_constructor),
        (rb_entry_view_sort_key_changed_cb):
        * widgets/rb-entry-view.h: fix a number of bugs with the RBEntryView
        sort-order (patch from James Livingston <jrl@ids.org.au>)
        (Closes: #306775)