After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 306074 - The menu accelerators in es.po need to be fixed
The menu accelerators in es.po need to be fixed
Status: RESOLVED FIXED
Product: dia
Classification: Other
Component: general
0.94
Other Linux
: Normal normal
: 0.95
Assigned To: Dia maintainers
Dia maintainers
Depends on:
Blocks:
 
 
Reported: 2005-05-31 19:36 UTC by Roland Stigge
Modified: 2005-10-08 20:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix for es.po (422 bytes, patch)
2005-05-31 19:37 UTC, Roland Stigge
committed Details | Review

Description Roland Stigge 2005-05-31 19:36:34 UTC
Distribution/Version: Debian

A Debian user found a translation issue with menus:

==========================================================================
In es_ES locale, these are the menus (with accelerators underlined and
English translations an parentheses):

_A_rchivo (file)
_E_ditar (edit)
_D_iagrama (diagram)
_V_ista (view)
_O_bjetos (objects)
_S_eleccionar (selection)
_H_erramientas (tools)
Metodos de _e_ntrada (input methods)
_A_yuda (help)

As you can see, the accelerators `A' and `E' are used twice.  This makes
no sense, as pressing Alt-A gives the Arhivo (file) menu the first time
and the Ayuda (help) menu the second time.

Metodos de entradad should be accelerated on `t' and Ayuda should be
accelerated on `y' (as is done with other GNOME apps; e.g.,
gnome-terminal).
==========================================================================

See also:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=310980

I'm attaching a patch that applies to current CVS.
Comment 1 Roland Stigge 2005-05-31 19:37:31 UTC
Created attachment 47074 [details] [review]
Fix for es.po
Comment 2 Alan Horkan 2005-06-01 13:21:43 UTC
File and Help are items that appear in almost every properly designed
application, so I just want to ask if you are sure the new accelerators you have
chosen match the standard ones?  

It would be very helpful if you could attach patches directly to bugzilla and
add the PATCH keyword.   



Comment 3 Alan Horkan 2005-06-01 14:05:57 UTC
sorry dont know why I asked you to attach the patch, thank you for already
having done so.  

the patch looks okay and I expect it will apply cleanly but for future reference
the preferred format is: diff -u 
(the exact format wanted is listed in this FAQ entry which I believe to be accurate
http://www.gnome.org/projects/dia/faq.html#MakingPatches )

Comment 4 Roland Stigge 2005-06-01 18:34:52 UTC
1) The patch has been created with diff -u
2) As documented in the Debian bug, the accelerator rules are the same as for
other gnome apps
Comment 5 Hans Breuer 2005-06-01 19:57:00 UTC
Thanks, applied. And sorry for the noise.

2005-06-01  Hans Breuer  <hans@breuer.org>

	* es.po: adjust acelerators, fixes bug #306074
	
Comment 6 Hans Breuer 2005-10-08 20:43:07 UTC
Adjusting target to help finding 0.94 dups already fixed