GNOME Bugzilla – Bug 305823
The rotate buttons on the toolbar are blurred
Last modified: 2006-11-14 18:35:50 UTC
This is because the 16x16 icons are upscaled to 24x24. 24x24 icons are necessary to fix this.
Created attachment 47275 [details] The two necessary icons
Created attachment 47276 [details] [review] patch to use the new icons in the code
Created attachment 47277 [details] stock-rotate-90-24.png First icon
Created attachment 47278 [details] stock-rotate-270-24.png the second icon
I'm not comfortable applying these patches so close to release; it's a lot of code for an aesthetic thing. I think the right thing to do would be to have these icons added to the Gtk+ stock icon collection. Leaving this open as a reminder to get these icons into gtk.
Tim, Thanks for commenting on the patch. I also think adding these icons to GTK is a good idea, but I don't think that's feasible anymore before the 2.12 release. Concerning your comment on the patch size I'm afraid I don't understand. The patch does not do much more then changing the function add_eog_icon_factory() which is called at startup. The code is simple and it is easy to verify that it works. (The icons show up correctly) Furthermore the patch can be tested for six weeks more until release. So I think it's safe to apply this patch Don't you agree with this? After 2.12 we should try to get these button then in the gnome-icon theme Regards, Jaap
I filed a bug (bug #321114) to request adding the rotate 90/270 stock icons to gtk+.
Lucas, I already filed to get them in gnome-icon-theme: bug 313387 and made this bug already depend on it. Probably also should have put that in a comment here. I think gnome-icon-theme is a better place because it already contains a lot of icons to manipulate images
Next time, add a comment, ok? It's more visible. Duplicate work is not good. I agree with you that gnome-icon-theme is a better place. I'll close the bug I reported. Thanks!
Again my apologies. I'll make sure I won't forget it again
The probability that the rotate icons get added to gnome-icon-theme in the 2.13 release window does not seem very high ( see bug 313387 ). Shall we go for the patch then. EOG is really starting to rock, would be a shame that it shipped in 2.14 with fuzzy icons. I don't mind updating the patch, if that is needed
It seems that rotate icons are missed for 2.16.x release too :-( But fortunately was added in the Icon Naming Specification 0.8.1 as: * object-rotate-left * object-rotate-right * object-flip-horizontal * object-flip-vertical I'll try to make a patch to use those named icons, stay tuned.
The mentioned icons object-flip-horizontal object-flip-vertical object-rotate-left object-rotate-right are now in g-i-t! So it would be nice for eog to use them and also respect the size (16x16 for menu, 24x24 for toolbar)
Created attachment 74856 [details] [review] Use fd.o named icos for rotate flip actions This patch will use the object-rotate* and object-flip* icons fron the Icon Naming Specification version 0.8. Those icons are yet available in gnome-icon-theme HEAD. Unfortunately there are no fresh g-i-t release, so we can't yet depend on it. Issues: there are no object-rotate-180 in Icon Naming spec and I think it will never be. So we could: a) remove Image->Rotate 180° - The same action could be performed using Rotate Left/Right twice b) Provide the new custom named icon "eog-object-rotate-180" (PNGs @ 16, 22, 24 and 32 pixels, SVG @ 48 pixels), install under $prefix/share/icons/hicolor/$size/actions Of course we have to draw new icon using Tango style (I could ask to Lapo who did the object-flip/rotate* icons). OK to commit?
Created attachment 74857 [details] [review] Use icons from fd.o only for rotate and flip Sorry, in the previous patch there was also a fix to use the named icon "image-loading" instead custom eog icon "loding.png". This is stuff for another bug. This patch switch to named icons only for rotate and flip actions.
(In reply to comment #15) > ...in the previous patch there was also a fix to use the named icon > "image-loading" instead custom eog icon "loding.png". This is stuff for another > bug. This shouldn't be a problem for too long as the eog-ng branch already uses "image-loading" to mark loading thumbnails.
(In reply to comment #15) > Created an attachment (id=74857) [edit] > Use icons from fd.o only for rotate and flip > > Sorry, in the previous patch there was also a fix to use the named icon > "image-loading" instead custom eog icon "loding.png". This is stuff for another > bug. > I'm testing this patch but I see these icons in an orange fashion, while the other ones are blue (most of them are GTK_ICON_*). I don't know if this is an issue related to the default icon theme in HEAD. Any idea?
Created attachment 76301 [details] EOG appearance with patch applied in HEAD
Created attachment 76302 [details] image menu
According with jimmac on irc, this is right. They don't want all icons to be blue, so we are fine. The problem is that the "rotate-180-degrees" icon is still blue, so we have two rotate icons on orange and one on blue, which is not really consistent. Solution: we need to get the rotate-180-degrees inside the naming spec. Once this goes in, we can update the patch, and apply it.
I opened a request for this in fd.o bugzilla. Let's wait to see what happens. https://bugs.freedesktop.org/show_bug.cgi?id=8961
Why do we need rotate-180? You can do rotate-left or rotate-right twice and get the same result... I would just remove the rotate-180 from eog.
(In reply to comment #22) > Why do we need rotate-180? You can do rotate-left or rotate-right twice and get > the same result... I would just remove the rotate-180 from eog. > As a side effect this would also free the Ctrl-Shift-R shortcut for counter-clockwise rotation which doesn't have an intuitive (any?) shortcut yet.
I was thinking about it last night, and agree with removing it. What does Lucas think about it?
I'm not Lucas, but I would like to share my thoughts about this issue. Rotate images is a common task. Very common. While less time takes to do the task, much better. If you delete that option, the user will take twice the time to flip a image. So, the question should be: "Is rotate 180° a common task?". If not, then should be deleted. If yes, well... think about it.
I think it is not really a common task. Moreover, evince has only rotate 90° and -90° options. I am all for removing it. Luca, want to update your patch?
For those people where rotating (and esp. 180° rotating) is a common action, they should think about using image-magick or somthing that can batch-process many images at once. I wouldn't want to manually apply the same thing to more than 3 pictures, and for less I don't mind clicking twice.
(In reply to comment #26) > I think it is not really a common task. Moreover, evince has only rotate 90° > and -90° options. I am all for removing it. Luca, want to update your patch? > The patch works fine with the latest HEAD. Do you mean remove rotate-180 entry and icon too? PS IMHO 'cause EOG is a _simple_ image viewer and not an image editor, the rotate-180 action could be removed. If you have to perform a 180° rotation, you can still perform a 90°+90°
Now I'm also convinced that remove rotare-180° is is right way to go.
(In reply to comment #28) > The patch works fine with the latest HEAD. Do you mean remove rotate-180 entry > and icon too? Right :-)
Created attachment 76348 [details] [review] New patch, use named icons for flip and rotate and remove rotate-180 Same as previous patch, plus removal of all (at least I hope) stuff related to rotate-180 (icons, menu entry, callback function). Of now the icon_factory registration is no longer required, removed this too.
Applied in HEAD. Thank you very much! Now we need to get a similar patch for the eog-ng branch, so we can get rid of the icons in the experimental branch. Would you do please it? In HEAD: 2006-11-10 Claudio Saavedra <csaavedra@alumnos.utalca.cl> * art/Makefile.am: Remove the icons. * art/stock-rotate-180-16.png: * art/stock-rotate-270-16.png: * art/stock-rotate-90-16.png: * art/stock-flip-horizontal-16.png: * art/stock-flip-vertical-16.png: * shell/eog-gtk-ui.xml: Remove rotate 180 degrees action. * shell/eog-window.c: (eog_window_construct_ui): Remove custom icon factory. Use stock icons for rotate and flip actions. (Fixes bug #305823). Patch from Luca Ferreti <elle.uca@libero.it>.
I ported the patch to eog-ng: 2006-11-14 Felix Riemann * Makefile.am: * art/.cvsignore: * art/Makefile.am: * art/stock-flip-horizontal-16.png: * art/stock-flip-vertical-16.png: * art/stock-rotate-180-16.png: * art/stock-rotate-270-16.png: * art/stock-rotate-90-16.png: * configure.ac: * data/eog-ui.xml: * shell/Makefile.am: * shell/eog-stock-icons.c: * shell/eog-stock-icons.h: * shell/eog-window.c: * shell/main.c: (main): Remove custom flip and rotate icons and use stock icons instead. Remove now obsolete files. Based on patch for HEAD by Luca Ferretti. Fixes bug #305823.
Thanks Felix! We can finally close this bug.