After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 305712 - gweather lists two weather locations both called "Charlottetown"
gweather lists two weather locations both called "Charlottetown"
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: gweather
git master
Other All
: Normal minor
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks: locations-love
 
 
Reported: 2005-05-27 23:59 UTC by Steven Garrity
Modified: 2005-06-09 14:42 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
Patch to rename CYYG from "Charlottetown" to "Charlottetown Airport" (656 bytes, patch)
2005-05-28 00:00 UTC, Steven Garrity 		reviewed Details | Review
Updated patch to use CITY tag (1.52 KB, patch)
2005-06-09 14:13 UTC, Steven Garrity 		committed Details | Review

Description Steven Garrity 2005-05-27 23:59:40 UTC 
Please describe the problem:
In gweather, under North America -> Canada -> Prince Edward Island, there are
two locations, both titled "Charlottetown".

One has the code CYYG and the other is CWYG.

CYYG is the "Charlottetown Airport" and should be labelled as such.
CWYG is a downtown Charlottetown weather station and can remain "Charlottetown"

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Steven Garrity 2005-05-28 00:00:56 UTC 
Created attachment 46968 [details] [review]
Patch to rename CYYG from "Charlottetown" to "Charlottetown Airport"

Here's a patch to rename the CYYG location from "Charlottetown" to
"Charlottetown Airport", so it doesn't have the same name as the other
Charlottetown weather station.
Comment 2 Danielle Madeley 2005-06-08 10:53:20 UTC 
I would like to propose a use of the <city> tag.

<city>
 <_name>Charlottetown</_name>
 <location>
  <_name>Airport</_name>
    ...
 </location>
 ...
</city>

There is a DTD available for you to test the file with using xmllint.
Comment 3 Steven Garrity 2005-06-09 14:13:01 UTC 
Created attachment 47506 [details] [review]
Updated patch to use CITY tag

Good call. Here's an updated patch that uses the City tag as you recommend.
Comment 4 Danielle Madeley 2005-06-09 14:22:36 UTC 
That looks great. Do you have commit access?
Comment 5 Danielle Madeley 2005-06-09 14:40:01 UTC 
2005-06-09  Davyd Madeley  <davyd@madeley.id.au>

        * Locations.xml.in: Fix Charlottestown. Closes bug #305712.