GNOME Bugzilla – Bug 305086
Make sure that all windows get a window icon
Last modified: 2005-07-27 10:06:43 UTC
Currently if you select for example Add in the tab Layout of the Keyboard capplet you get a window without an icon. Upcoming patch makes sure that all windows get an icon when the capplet_set_icon function is used
Created attachment 46744 [details] [review] patch fixing this
where do you have the window without an icon?
Click for example on for Add in the tab Layout of the Keyboard capplet and you get a window without an icon.
where do you want to get an icon? That's the same application as the keyboard capplet for the window manager and the windows list applet so there is only one entry which has an keyboard icon. Can you make a screenshot of your issue?
Created attachment 46756 [details] screenshot showing problem before the patch You see the window does not have a keyboard icon
right, that's depending of the window manager theme.
Created attachment 48587 [details] [review] Better version Old patch * set the default icon This patch * set the icon of the window * set the default icon With the old patch the icon of the capplet will change if the programmer decides to call gtk_window_set_default_icon after using capplet_set_icon. That's probably confusing
why setting a default instead of gtk_window_set_icon () with the appropriate icon on every window?
My patch just adds a gtk_window_set_default_icon it keeps gtk_window_set_icon_name. The icon provided to gtk_window_set_default_icon is the icon which will be used for any window created in the capplet on which the programmer does not call a gtk_window_set_icon. Most programs just want one icon for all the windows. For that gtk_window_set_default_icon is very handy. If you want to give specific windows another icon you just call gtk_window_set_icon. So in my opinion this patch is correct. Do you agree?
I guess that's fine, I've pushed the change with set_default before set_icon. Any reason for to call set_icon before set_default_icon? 2005-07-27 Sebastien Bacher <seb128@debian.org> * capplet-util.c: (capplet_set_icon): set a default icon for capplets, patch by Jaap A. Haitsma <jaap@haitsma.org> (Closes: #305086).
Thanks! The order of set_icon and set_default_icon does not matter in this case