After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 304103 - Gtk::Widget:"show_help" signal not wrapped
Gtk::Widget:"show_help" signal not wrapped
Status: RESOLVED FIXED
Product: gtkmm
Classification: Bindings
Component: general
2.6.x
Other All
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on: 339205
Blocks:
 
 
Reported: 2005-05-13 19:32 UTC by Philip Langdale
Modified: 2016-11-05 08:50 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Philip Langdale 2005-05-13 19:32:52 UTC
Both of these signals are important for accessibility keyboard navigation and
are trivially wrapped. Do you have any objection to me doing this?
Comment 1 Murray Cumming 2005-05-14 11:07:01 UTC
We ususually don't wrap the accessibility ("keybinding" or G_SIGNAL_ACTION)
signals. The GTK+ developers told us that these should never be used outside of
GTK+ and we had problems between 2.0 and 2.2 when they changed the signatures of
the signals, breaking our build. From their point of view they were private API
that we shouldn't have been using.

But maybe this is a special case. You could ask on gtk-list whether you should
be using them to do whatever it is you are trying to do.
Comment 2 Philip Langdale 2005-05-14 15:30:10 UTC
Well, in the case of 'popup_menu' that really makes no sense. Any widget that
has a popup menu should attach a callback to this signal. Otherwise it's
incredibly difficult to respect keybindings. Attaching to key_press and hard
coding detecting for the menu and shift-f10 keys isn't acceptable because the
user can customise the keybinding for showing the popup menu.

As it's possible to write a widget in gtkmm, then it must be necessary to have
access to the popup_menu signal. It most certainly is not an internal gtk+
implementation detail.

http://developer.gnome.org/doc/API/2.0/gtk/gtk-migrating-checklist.html#checklist-popup-menu
Comment 3 Murray Cumming 2005-05-15 10:46:15 UTC
Again, please ask on gtk-list whether gtkmm should wrap this.
Comment 4 Murray Cumming 2005-06-09 09:38:44 UTC
If you won't do that, then this is not major.
Comment 5 Philip Langdale 2005-06-10 05:43:26 UTC
I sent an email to gtk-list. Apparently it never made it through moderation.
I'll have to try again.
Comment 6 Kenneth Haley 2005-07-07 23:11:46 UTC
Murray, GTK+ dicumentation is quite clear on this.  The popup_menu is supposed
to be used by applications.  It's part of the migration check list.
Comment 7 Calum Benson 2006-04-26 17:13:26 UTC
Apologies for spam... ensuring Sun a11y folks are cc'ed on all current accessibility bugs.
Comment 8 Murray Cumming 2006-05-18 18:01:54 UTC
I've still had no luck getting the GTK+ developers to document that these keybindings are an exception to the usual don't-wrap-keybinding-signals rule.
Comment 9 Murray Cumming 2007-11-05 11:57:47 UTC
I have wrapped popup-menu in svn trunk, but I still see no evidence that show-help is meant to be used. See bug #339205.

Comment 10 Murray Cumming 2008-05-16 16:37:40 UTC
Maybe it would help to know of an application that uses this signal.
Comment 11 Kjell Ahlstedt 2016-11-05 08:50:37 UTC
The GtkWidget::popup-menu signal was wrapped in gtkmm long ago.
The GtkWidget::show-help signal has been removed from gtk+'s master branch,
meaning (I suppose) that it will not be included in gtk+-4.0.

This bug can be closed now.