After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 303850 - Put some pixels empty space between togglebuttons in panel
Put some pixels empty space between togglebuttons in panel
Status: RESOLVED WONTFIX
Product: libwnck
Classification: Core
Component: tasklist
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libwnck maintainers
libwnck maintainers
Depends on: 304548
Blocks:
 
 
Reported: 2005-05-11 21:38 UTC by Jaap A. Haitsma
Modified: 2007-03-25 20:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The patch (2.92 KB, patch)
2005-05-11 21:39 UTC, Jaap A. Haitsma
none Details | Review

Description Jaap A. Haitsma 2005-05-11 21:38:27 UTC
This can be pretty irritating and confusing (especially if you use sloppy window
mode)

Patch coming up which always brings window to the foreground if you click on the
task button
Comment 1 Jaap A. Haitsma 2005-05-11 21:39:46 UTC
Created attachment 46347 [details] [review]
The patch
Comment 2 Elijah Newren 2005-05-11 22:53:48 UTC
This used to be the behavior and it was intentionally changed (see bug 79500). 
We'd need a really good reason to change it.
Comment 3 Elijah Newren 2005-05-11 22:56:42 UTC
(Also, note that if you find it confusing due to sloppy/mouse focus as opposed
to click to focus, the real bug you may want to fix is bug 90134; see also bug
129897)
Comment 4 Jaap A. Haitsma 2005-05-12 15:08:52 UTC
Thanks for the pointers. I guess one of the main problems is that with many
themes it is difficult to see which taskbutton is currently on in the window
list. A thing I guess that could help is enlarge the spacing between the buttons
and maybe change the button more drastically. In Windows for example you get a
kind of dotted pattern as background. 

2 Questions?

1. Would spacing need to aranged in libwnck or in the themes?
2. same question for the dotted pattern.
Comment 5 Elijah Newren 2005-05-13 15:08:27 UTC
I have no clue...maybe Havoc, Mark, or Vincent knows...

(retitling based on your current questions/suggestions)
Comment 6 Havoc Pennington 2005-05-14 16:57:35 UTC
spacing between buttons is in libwnck. Changes to the button are hard to do in a
theme-friendly way (see bug 120439 for another example)
Comment 7 Vincent Untz 2005-05-31 11:57:40 UTC
Isn't this more of a theme issue? I mean, if it's not clear whether a button is
activated or not, then the theme is wrong, isn't it?
Comment 8 Jaap A. Haitsma 2005-05-31 16:49:57 UTC
Partly. One of thing that would improve clearness is standard putting some space
between the the toggle buttons. The 3D effect of the buttons is then better
visible. I noticed now that the Clearlooks theme is CVS somehow created some
space between the buttons. But I guess that is for all togglebuttons. I
contacted the author but haven't received a reply yet.

Changing title of this bug to
"Put some pixels empty space between togglebuttons in panel"

Adding empty space is quite simple with the 
void        gtk_container_set_border_width  (GtkContainer *container,
                                             guint border_width);
call, but unfortunately it adds spacing on all 4 sides. I filed a bug 305117 on
it to have a call using GtkBorder, but that's a lot of work according to Owen
Taylor. He suggests to use GtkAlignment instead. I've looked in to this but
don't see an easy solution. Every task needs a button object. So I don't see how
I can get a GtkAlignment in there

Comment 9 Jaap A. Haitsma 2007-03-25 20:02:40 UTC
I'll give up on this request I had. Some of the theme authors already solved this in the themes. So I'll close it.