After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 302400 - close dialog's labels included in focus chain
close dialog's labels included in focus chain
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
2.2.x
Other All
: Normal minor
: 2.2
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks: 319962
 
 
Reported: 2005-04-29 08:50 UTC by Jakub Steiner
Modified: 2008-01-15 12:53 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jakub Steiner 2005-04-29 08:50:11 UTC
The close dialog lets me tab to the dialog labels making it more inconvenient to
tab to the "don't save" button. One could argue it makes it easy to select the
text for pasting to a help forum or somesuch, but that doesn't seem to be
possible either (selection gets reset) and I wouldn't consider that being more
common case anyway.

The 2.2.4 version shipped with SUSE actually lost control focus completely after
tabbing out of the labels which was my initial intention to file as a bug, but I
don't have access to that box anymore. Will see about cvs HEAD and comment ASAP.

Other information:
To reproduce - 
1) scribble something onto a new canvas
2) close image, dialog pops up
3) in 2.2.2 the focused button is correctly set on cancel
4) pressing tab twice will not get you to the "don't save" button, but to the
dialog header label
Comment 1 Sven Neumann 2005-04-29 13:53:18 UTC
GTK+ 2.6 changed behaviour and now includes selectable labels in the focus
chain. This is the main reason for this behaviour.
Comment 2 Sven Neumann 2005-04-29 14:02:41 UTC
Fixed in both branches:

2005-04-29  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpmessagebox.c (gimp_message_box_init): unset
	"can-focus" on the message labels. Fixes bug #302400.


BTW, selecting the label to paste the text is supposed to work (and works for me).
Comment 3 Jakub Steiner 2005-05-01 21:21:03 UTC
I'm guessing the problem with copy-pasting was the fact the timer reset the
selection ("You will lose 3.4.5 seconds of work..").
Comment 4 Sven Neumann 2005-10-31 17:10:02 UTC
Changed the fix in the HEAD branch:

2005-10-31  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpmessagebox.c (gimp_message_box_init): reverted
	the change for bug #302400; it caused bug #319962 to be opened.
	Instead unset the focus chain for the message box.