GNOME Bugzilla – Bug 301969
Evince should have an epiphany style zoom combobox in the tool bar.
Last modified: 2006-10-23 23:59:09 UTC
As above. A useful enhancement beyond what ephiphany does would be to include the 'Best Fit' and 'Fit Page Width' options in the combobox. It may be nice to put these below a seperator, too.
Created attachment 45670 [details] [review] WIP patch. Zoom levels are working, and the control updates to display the closest zoom level, if the level is changed through the menu, for example. Still have to get the Best Fit etc options working.
Combobox is nice for jumping to very high and very low scale, but quite often task is to make document a bit bigger or a bit smaller. Changing from Fit Width to Fit both in this case will require significant actions, like cursor positioning. So at least like in nautilus browser button there should be zoom in and zoom ut buttons on the sides of control. Let's import epiphany toolbar editor, then everyone could set toolbar as hi likes.
And of course having control in addition to buttons would be nice.
Created attachment 45676 [details] [review] Features working. Zooming and choosing 'best fit' or 'fit page width' now work from the toolbar combo box. The control also updates itself when zooming etc is changed elsewhere. Unfortunately, I couldn't get a separator in there. If one is wanted, I suppose we could write a separator cell renderer to use with the combo box, or switch to a ToolbarMenu (Though this will look and behave differently).
To put a separator in the combo box, you cannot use gtk_combo_box_new_text; you have to construct the cell renderer and the model yourself. See epiphany's src/ephy-toolbar-editor.c:ephy_toolbar_editor_constructor() for an example with a separator.
Created attachment 45681 [details] [review] Now with separator! Sweet! Thanks for pointing that out, Christian. This patch is the same as the previous, but now the combobox has a separator between the zoom percentages and the zoom modes.
Yeah, that looks good. The values for zoom are something we'll probably have to tweak with some testing, but I like this a lot better. Awesome work!
This is now in CVS. We still have to get good zoom values, though.
I am reopening this bug because we have been talking about a different style zoom widget in epiphany for a long time, but want to stay consistent with evince. See bug 117923. Please comment.
I see that the patch is committed; note that Epiphany 1.9.x now has two simple "Smaller" and "Larger" buttons on the default toolbar layout. The combobox is still available as optional widget.
Reinout, can I close this bug?
Closing. One remaining question is whether evince could benefit from "smaller/larger/fit width/fit page" buttons on the toolbar, instead of the combobox widget.