GNOME Bugzilla – Bug 301624
Some mail config strings are not translated by the lack of gettext() calls.
Last modified: 2013-09-10 14:04:04 UTC
Please describe the problem: In em-account-editor, N_() marked strings (in emae_editor_items and emae_druid_items) are not actually translated. Steps to reproduce: 1. run evolution in a non-English locale. 2. Edit-Preferences and edit a mail account Actual results: "Receiving Options" tab is not transalted. Expected results: translated "Receiving Options" Does this happen every time? Always. Other information:
adding dependency.
Attaching a patch which fixes this problem.
Created attachment 46086 [details] [review] Proposed patch
I think the patch lacks handling of E_CONFIG_DRUID case. How to reproduce: 1. Add a mail account 2. Set the server type IMAP Then several config labels and title ("Receiving Options") are untranslated.
Umm, for starters, e-config is a generic re-usable object. saying "receiving options" is now translated in the comment is meaningless. Anyway - this fix is no good. The strings must come into the item already translated - they may come from plugins which are translated in their own message domain & so wont be translated properly by this fix. So the strings need to be translated in the code for statically allocated stuff too, I guess.
Created attachment 46445 [details] [review] proposed patch revised As NotZed said. it makes the strings already translated.
*** Bug 305572 has been marked as a duplicate of this bug. ***
marking the first patch as "obsolete" because of the comments, should review the second approach
the secodn patch looks good for the first part. the second part is wrong though, it translates every item, but it should only translate item 1, item 2 is already translated when it needs to be (which is only sometimes)., and nothing else has a string. (didn't you see that the line directly above your change also does translations?)
*** Bug 308690 has been marked as a duplicate of this bug. ***
still in 2.4. targetting to 2.4.3 because this was already broken in 2.2 and should definitely go in. it IS allowed to commit this to the stable and the unstable branch according to the guidelines.
Created attachment 56658 [details] [review] Patch which fixes the issue Incorporating !z's comment into Changwoo Ryu's patch.
Looks fine. Ok to commit.
Committed to stable and unstable branches.