GNOME Bugzilla – Bug 301120
strings are not translated
Last modified: 2005-05-17 14:49:46 UTC
Please describe the problem: Some strings remains untranslated in the evolution mail composer. It's because the strings in XML files are not properly translated. Steps to reproduce: 1. run evolution in any non-english locale 2. new mail 3. From menu: Format -> Paragraph... Actual results: strings "_Style:", "Alignment", "Left", "Center" and "Right" remain untranslated. Expected results: translated strings expected. Does this happen every time? Always. Other information: This needs to be fixed along with libbonoboui(). Currently we have no way to specify the translation domain with bonobo_ui_util_*() functions. See bug 301118 .
Well, I was wrong. It's not relevant to bonobo. It is because of the gnome-i18n.h => gi18n.h changes in gnome-2-10 branch. This should be gi18n-lib.h. Some file still uses gnome-i18n.h and some even uses bonobo.h which in turn includes bonobo-i18n.h. Therefore some file uses the explicit translation domain, some does not.
Created attachment 45564 [details] [review] fixes untranslated strings It replaces <gi18n.h> with <gi18n-lib.h>, defines BONOBO_EXPLICIT_TRANSLATION_DOMAIN, and specify the domain of the glade file. Defining BONOBO_EXPLICIT_TRANSLATION_DOMAIN, along with GNOME_EXPLICIT_TRANSLATION_DOMAIN, is dirty. But some file still uses gnome-i18n.h and others uses bonobo-i18n.h (via other bonobo header) so I can't find no cleaner way.
still valid in evolution-2.2.2.0.200504141611-0.snap.ximian.10.1, targetting to 2.3 (i assume these strings aren't translated, but if they are, please retarget to 2.2.x). adding dependency.
The strings are translated. Just not displayed. Retargetting to 2.2.x...
Created attachment 46141 [details] [review] updated patch to let the exe component just use the implicit domain applied to the cvs.
Commited to gnome-2-2, reviewed by Radek Doulik. Should I commit this also to HEAD?
Yes, Please commit to HEAD aswell.
Commited to HEAD.