After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 300191 - speech report should stop when switching terminal tabs
speech report should stop when switching terminal tabs
Status: RESOLVED FIXED
Product: gnopernicus
Classification: Deprecated
Component: speech
unspecified
Other Linux
: Normal normal
: ---
Assigned To: remus draica
remus draica
AP2
Depends on:
Blocks:
 
 
Reported: 2005-04-11 14:18 UTC by John Crawley
Modified: 2005-04-26 08:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed pach (853 bytes, patch)
2005-04-21 10:31 UTC, remus draica
committed Details | Review

Description John Crawley 2005-04-11 14:18:42 UTC
Distribution/Version: JDS Rel 3 B32

Using gnopernicus 0.10.5

 - Start gnopernicus with speech enabled.
 - Open up a terminal.
 - Create a new tab in the terminal window.
 - While focussed the second tab, type "ps -ef"
 - Switch to the first tab.

Notice that there is still speech output for the "ps -ef" command.
Thankfully, it can be stopped by pressing <control>, but it should
stop automatically as soon as the user switches tabs or accesses a menu.
Comment 1 bill.haneman 2005-04-11 14:51:52 UTC
I believe this is a duplicate of the 'in process' issue in bug #169480, which
has been patched in cvs HEAD.
Comment 2 bill.haneman 2005-04-11 14:53:35 UTC
see http://bugzilla.gnome.org/attachment.cgi?id=39711&action=view
for a patch which should correct this problem.  Or please try with the latest
gail from cvs head.
Comment 3 Alexandra Telescu 2005-04-19 09:32:03 UTC
Using Gonpernicus from CVS HEAD, 19th April, with the patch from bug #169480,
comment 68, and Gail from CVS HEAD 19th April, I observed that if I move to
another tab and I use the shutup key, the speech stops and only the characters
typed in the new tab begin to be reported.
Closing as a duplicate of bug #169480, please reopen if it's necessary.


*** This bug has been marked as a duplicate of 169480 ***
Comment 4 John Crawley 2005-04-19 09:37:45 UTC
Alexandra, speech should stop reporting the old tab as soon as the new tab is 
focussed. The user shouldn't need to use the shutup key at all.
If this behaviour is audible on your setup, please close this bug as a duplicate
again.
Comment 5 remus draica 2005-04-21 10:31:16 UTC
Created attachment 45508 [details] [review]
proposed pach


The patch sends text-insert events for terminal with lower priority than other
events.
Comment 6 bill.haneman 2005-04-21 10:43:51 UTC
I don't understand why this patch is necessary; when the user focusses a new
tab, the old one should interrupt all of the speech from the previous one.  Why
doesn't the new focus event cause the old terminal speech to be stopped anyway?
Comment 7 remus draica 2005-04-21 10:55:42 UTC
Now text-insert and focus have same priority. Beside that, the text-insert
events for terminal have the un-interruptible flag set (this way user gets the
entire output from a terminal, not only the last). Because it is
un-interruptible, the new focus event doesn't interrupt it(it is placed in the
speech queue where waits till all insert event are spoken). If insert events
have lower priority, they will be interrupted by the new focus, even if
un-interruptible flag is set.
Comment 8 bill.haneman 2005-04-21 12:17:43 UTC
Thanks Remus, I see.

Are there situations where other events of 'NORMAL' priority might interrupt the
terminal output undesirably?

Comment 9 remus draica 2005-04-26 08:01:54 UTC
Bill, I don't know a case you described above.