After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 273099 - Please provide translator comment for Evolution csv plugin message
Please provide translator comment for Evolution csv plugin message
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Philip Van Hoof
Evolution QA team
: 273098 (view as bug list)
Depends on:
Blocks: 236276
 
 
Reported: 2005-02-27 23:06 UTC by Christian Rose
Modified: 2009-08-03 15:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch v1 (953 bytes, patch)
2005-02-28 09:42 UTC, Philip Van Hoof 		none Details | Review
What about this one (3.28 KB, patch)
2005-02-28 16:17 UTC, Philip Van Hoof 		none Details | Review
And without the tiny memoryleak :) (3.30 KB, patch)
2005-02-28 16:23 UTC, Philip Van Hoof 		none Details | Review
And yet another tiny mistake corrected (3.31 KB, patch)
2005-02-28 16:30 UTC, Philip Van Hoof 		none Details | Review
Solves both #73099 and $7398 (6.88 KB, patch)
2005-03-02 22:23 UTC, Philip Van Hoof 		none Details | Review

Description Christian Rose 2005-02-27 23:06:49 UTC 
#: plugins/save-calendar/csv-format.c:167
#, c-format
msgid "%s%d/%s%d/%s%d %s%d:%s%d:%s%d"

Please provide a translator comment for this message, explaining how its
used and what kind of values get filled in at the various %s and &d:s.

As the message is right now, it is very difficult for a translator to know
how to translate this or if he needs to translate it at all.
Comment 1 Christian Rose 2005-02-27 23:11:35 UTC 
After looking at the code, this piece of code seems entirely broken
from a localization point of view. Why not just use strftime() and a
format string of "%x %X" instead?
Comment 2 Christian Rose 2005-02-27 23:15:00 UTC 
Please note though that GNOME is currently in string freeze.
Comment 3 Philip Van Hoof 2005-02-28 09:42:28 UTC 
Created attachment 44900 [details] [review]
patch v1
Comment 4 Christian Rose 2005-02-28 10:45:40 UTC 
I'm cc:ing Danilo to see if he thinks this should be translateable or not.

To clarify, if you decide to only remove the message from translation,
you would not need string freeze approval. Removing is fine from a
string freeze point of view.
Comment 5 Danilo Segan 2005-02-28 13:27:34 UTC 
This all looks very strange.  If it should not be translated (I don't
know how are generated CSV files used), and if it's not mandated by
some specification, I suggest to make the date format YYYY-MM-DD
instead (which is universally understood, whereas MM/DD/YYYY will most
likely be misunderstood in Europe, at least).

Also, why not use "%02d" instead of those hacks there?
Comment 6 Philip Van Hoof 2005-02-28 16:17:54 UTC 
Created attachment 44902 [details] [review]
What about this one
Comment 7 Philip Van Hoof 2005-02-28 16:23:16 UTC 
Created attachment 44903 [details] [review]
And without the tiny memoryleak :)
Comment 8 Philip Van Hoof 2005-02-28 16:30:35 UTC 
Created attachment 44904 [details] [review]
And yet another tiny mistake corrected
Comment 9 Philip Van Hoof 2005-02-28 16:33:20 UTC 
*** bug 273098 has been marked as a duplicate of this bug. ***
Comment 10 André Klapper 2005-02-28 18:15:59 UTC 
adding dependency, adding "patch" keyword
Comment 11 Philip Van Hoof 2005-03-02 12:46:52 UTC 
Fixed in CVS
Comment 13 Philip Van Hoof 2005-03-02 22:23:59 UTC 
Created attachment 44923 [details] [review]
Solves both #73099 and $7398
Comment 14 Danilo Segan 2005-03-02 22:50:25 UTC 
Hasn't evo already branched for gnome-2-10? I.e. you don't need
approval for HEAD, only for gnome-2-10 (and it's not important enough
to warrant a string freeze break this late).
Comment 15 Danilo Segan 2005-03-02 22:54:08 UTC 
Reopening until it gets fixed in at least HEAD.
Comment 16 André Klapper 2005-07-13 17:31:20 UTC 
philip, danilo, can this be closed now according to 2.3.2 release notes it
should be in.
Comment 17 Philip Van Hoof 2005-07-13 17:38:21 UTC 
Indeed
Comment 18 Max Kanat-Alexander 2009-08-03 15:23:42 UTC 
Comment on attachment 44900 [details] [review]
patch v1

Original description was too long for the soon-to-be-upgraded Bugzilla.