GNOME Bugzilla – Bug 270605
Disable account which is default comes as 'organizer' while creating meeting
Last modified: 2009-07-23 12:10:26 UTC
Please fill in this template when reporting a bug, unless you know what you are doing. Description of Problem: Steps to reproduce the problem: 1.Configured an account test1 exchange account, disbaled it, restarted evolution. 2. Configured test2 account. 3. Now click on New ->Meeting, under 'Invitations' tab, u can see diabled account id in organizer field Not a general user scenario, so 'Normal' priority is set Actual Results: Expected Results: Current account which is enabled should come by default How often does this happen? Always Additional Information:
This is quite borderline for not to be "normal"
The fix for #71432 should fix this as well. Closing this bug.
bug 271432 is fixed and verified but this issue is not yet resolved.
Sounds more like a calendar UI problem ?
Created attachment 91105 [details] [review] proposed patch for evolution; Only one question: Do we need to see there disabled account(s)?
Im not sure, what the patch does? Also I think it is fine, if we hide disabled accounts.
It is not good to hide the disabled mail accounts. If the user wants to send using a disabled mail account, he will have to reopen a new meeting editor after enabling the account. There can be users who just use evolution for calendaring. How about doing the following ? If the default account is not enabled, select the enabled account. If none of the account are enabled, select the default account and show a warning message saying, "You have selected a disabled account for sending your message, do you want to enable it ?" and open the account preferences based on the response ? [must not be intrusive]
Chenthil, Im not sure do we need the disabled accounts to be shown here. Even the composer hides the disabled accounts.
As I have said, and to be consistent with composer, lets not add disabled accounts to the editor at all. That would completely solve the problem, instead of this.
Created attachment 94235 [details] [review] proposed evo patch for evolution; improved one.
*** Bug 342935 has been marked as a duplicate of this bug. ***
Reworked the fix as the previous commit made changes in the same area. Fix has been been committed.
Created attachment 95243 [details] [review] patch in evolution/calendar/gui/dialogs/*-page.c The memo editor would still show disabled accounts.. the patch fixes that issue.. Also, priv->default_address in (event/task/memo)-page.c is used only by the *_page_select_organizer function.. Hence, some code-cleanup..
Created attachment 97042 [details] [review] patch in evolution/calendar/gui/dialogs/*-page.c The memo editor would still show disabled accounts.. the patch fixes that issue.. Also, priv->default_address in (event/task/memo)-page.c is used only by the *_page_select_organizer function.. Hence, some code-cleanup.. Also, the patch fixes this issue: 1) Open an existing assigned task (preferably a task which has been assigned to you) 2) see the organizer combo-box.. it does not show the correct organizer of the assigned task.. instead it shows a default list [something which should happen only if you are creating a *new* assigned task]
Pity, I reworked same part too, in my patch for bug #439122.
Suman, Im rejecting this, as I have approved the other one.If something unique this provides, extract and attach that alone.
Suman, try to look into that bug #439122, if you can/need use something from there, (related to *-page.c source files, because other parts has been fixed already within other bugs, so I will not commit that patch there. There has been done some changes in the code, so your patch doesn't apply smoothly, so try to attach improved one. I see these lines unique in your patch: if (!priv->user_org) { list = g_list_append (list, string); gtk_combo_set_popdown_strings (GTK_COMBO (priv->organizer), list); gtk_editable_set_editable (GTK_EDITABLE (GTK_COMBO (priv->organizer)->entry), FALSE); } So these (together with others related) fix this bug.
Suman, please take care about that leak fix I mentioned in that bug.
Created attachment 102051 [details] [review] patch in evolution/calendar/gui/dialogs/*-page.c (In reply to comment #16) > Suman, Im rejecting this, as I have approved the other one.If something unique > this provides, extract and attach that alone. > Resolves issues mentioned in comment #14 + fixes a memory leak (thanks to Milan :-) ) Srini.. the patch applies on SVN trunk.. so it is unique ;-)
The patch looks good to me. Have a quick look Srag, if you wish, but I think we can approve it.
Milan, I go by your confidence. Please approve to commit.
thanks for the reviews guys.. Committed to SVN trunk as r34763 (http://svn.gnome.org/viewvc/evolution?view=revision&revision=34763)
*** Bug 272656 has been marked as a duplicate of this bug. ***