GNOME Bugzilla – Bug 264453
Insert Link pop-up needs love
Last modified: 2005-10-28 10:42:57 UTC
Description of Problems: 1. The pop-up dialog that appears when composing HTML email (*ahem* not that I would ever do such a thing...) is not very friendly. Currently there is a "Help" button (completely BROKEN for me--Help works elsewhere in Evo), and a "Close" button. I humbly suggest that there should be a "Insert" button and a "Cancel" button. Currently the button that performs the link-insertion is labeled "_Close", which is not at all intuitive to me--the user is not informed that this button will do anything but close the window--and of course, a cancel action (currently only available by pressing Esc) would be desirable. I'm not sure what the HIG would have to say about this. 2. Furthermore, the "Visit" button needs a little more logic, if it is to stay at all. It should be disabled if no valid-appearing URL is in the entry field. Currently clicking it with a completely blank entry will open a blank page in my browser. I actually think this button should say "Test link" or "Test URL", which is IMHO more intuitive. 3. Thirdly, and perhaps this should be a separate bug--there is no way that I can see to edit an existing link (or even see what a link would lead to) in the composer. When writing a message with several links, if you're unsure about what link you pasted in, the only current alternative seems to be deleting the linked text and re-inserting it. Steps to reproduce the problem: 1. Open a new message window 2. Select Format->HTML 3. Select Insert->Link Additional Information: gtkhtml3.1-3.1.20.0.200408240630-0.snap.ximian.6.1 evolution1.5-1.5.93.0.200408240630-0.snap.ximian.6.1 libgtkhtml3.1_11-3.1.20.0.200408240630-0.snap.ximian.6.1 evolution-data-server-0.0.98.0.200408240630-0.snap.ximian.6.1 libsoup2.2-2.1.13.0.200408240630-0.snap.ximian.6.1 libgal2.2_0-2.1.14.0.200408240630-0.snap.ximian.6.1
still valid in evolution-2.2.0.0.200503210410-0.snap.ximian.10.1; retargetting to 2.3.
*** Bug 236460 has been marked as a duplicate of this bug. ***
also when entering a link on a text, you cannot add an explanation text (a "title" tag on the link i guess), but you can do when trying to add a link on an image (also see bug 310585). running gtkhtml-3.7.4 here.
first and second one still valid in 2.4.0. third one (removing a link) is possible from context menu when clicking on a link text in composer. retargetting to 2.5.
Created attachment 52685 [details] [review] patch changed text from URL to Test URL.Added the Cancel button.Changed the close button to OK button for clarity.
Oswald: Some comments on your patch, - The URL text is correct. What needed to be changed was the 'Visit' text on the button. - With the patch, Ok button with an enter key accelerator icon would be seen by the user. However, enter key does not close the dialog, so we need to fix that if we change the button. - The Cancel button is not very useful as of now. Cancel button usually helps to forget or overlook the changes made in the dialog by the user. However, since the link dialog is of instant apply type, the cancel button becomes identical in functionality to Close/OK button.
Submitter: 1) We cannot replace the Close button with anything else, since it is an instant apply dialog. 2) 'Visit' has been made 'Test URL'. 3) You can edit the link by right-click context menu's 'Insert link' option. You can edit the link description text by directly editing it in the composer window.
Note: Help does not work because the help documentation does not exist for gtkhtml as yet. you could file a separate bug under documentation for the same. once the document is in place, I could hook up the help buttons onto the relevant sections.