GNOME Bugzilla – Bug 264404
calender day/week summaries does not allow 'Enter' in preedit mode.
Last modified: 2008-01-14 20:21:36 UTC
Please fill in this template when reporting a bug, unless you know what you are doing. Description of Problem: In Ja locale calender day/week summaries does not allow 'Enter' in preedit mode. Steps to reproduce the problem: 1. Launch evolution in ja locale and click local folder->Calendar; 2. Enter an appointment. 3. Try to edit the summary in day/week view mode inline. Change to preedit mode and enter some japanese chars. 4. Press 'Enter' to commit. 5. It's not getting committed. Actual Results: Enter don't have any effect Expected Results: Enter should commit the preedit buffer How often does this happen? Always Additional Information:
Created attachment 44131 [details] [review] calender patch
See also http://bugzilla.gnome.org/show_bug.cgi?id=263731 These two patches must be applied to solve the preedit issue.
This bug doesn't happen on open source Japanese input method, with gal CVS HEAD and evolution CVS HEAD.
== Bug test on gal CVS HEAD and evolution CVS HEAD == #63731 is applied but this #64404 is not applied I used 'nihongo' as the Japanese input string. Press 'a' first to make item editable and Shift+Space or Control+Space to start preedit mode. Bug appearance: im-canna(snooper on) NO im-freewnn(snooper on) NO im-canna(snooper off) NO im-freewnn(snooper off) YES im-xim(kinput2 -canna, no snooper) YES im-iiim(CannaLE, no snooper) YES Bug appearance after the patch applied: http://bugzilla.gnome.org/attachment.cgi?id=44131 im-canna(snooper on) NO im-freewnn(snooper on) NO im-canna(snooper off) NO im-freewnn(snooper off) NO im-xim(kinput2 -canna, no snooper) NO im-iiim(CannaLE, no snooper) NO Snooper is the feature to avoid http://bugzilla.gnome.org/show_bug.cgi?id=90082 bug. It uses gtk_key_snooper_install() and get all key events earlier than applications' shortcut key combo. Owen, GTK+ officiel denies this way of fix and snooper is known to introduce another weird behaviors. But that is popular among Japanese immodule developer, because it fixes one of the most important bug in GTK+. For this #64404 bug, im's snooper function get GDK_Return before evolution so the bug does't appear. Im-canna without snooper feature works in both cases so I feel like immodule implementation could be the real problem. Anyway, adding !E_TEXT (item)->preedit_len does not break input method behavior. I cannot find any reason to disagree to this patch now.
Really appreciate your detailed testings on this. Will wait for evolution maintainers to approve. BTW, how's the work with gal/e-text going ?
adding "patch" keyword
patch has not been applied yet, i assume that it still should go in?
Bug 303873 seems to be the same as this bug.
Created attachment 99017 [details] [review] updated calendar patch for evolution; This is only updated calendar patch above, to be applicable on actual sources. I think we can accept it, it seems to me that it will not break anything.
Please commit the patch.
Committed to SVN trunk as r34808 (http://svn.gnome.org/viewvc/evolution?view=revision&revision=34808)
*** Bug 303873 has been marked as a duplicate of this bug. ***