After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 263236 - It's unclear that deleting from a vFolder actually deletes email from other folders
It's unclear that deleting from a vFolder actually deletes email from other f...
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.22.x (obsolete)
Other other
: Normal enhancement
: Future
Assigned To: Milan Crha
Evolution QA team
evolution[vfolders]
Depends on:
Blocks:
 
 
Reported: 2004-08-17 17:15 UTC by B Cowgill
Modified: 2013-09-13 00:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed evo patch (5.16 KB, patch)
2007-10-12 13:45 UTC, Milan Crha
needs-work Details | Review
proposed evo patch ][ (7.48 KB, patch)
2007-11-06 12:24 UTC, Milan Crha
committed Details | Review
proposed evo patch ]I[ (1.36 KB, patch)
2007-11-13 11:29 UTC, Milan Crha
none Details | Review
proposed evo patch IV (1.36 KB, patch)
2007-11-13 13:14 UTC, Milan Crha
committed Details | Review
proposed evo patch (1.63 KB, patch)
2007-12-06 13:40 UTC, Milan Crha
committed Details | Review

Description B Cowgill 2004-08-17 17:15:54 UTC
Description of Problem:
Deleting mail from a vFolder does not warn you
that it will actually delete the mail from your
inbox or other folder in addition to the vFolder


Steps to reproduce the problem:
1. Click on a vfolder like Unmatched.
2. Select an email and delete it.

Actual Results:
No warning message.  Go to inbox or other folder
and the mail is gone forever, no undo either.
A good warning message would be "Warning deleting
email from a vFolder will delete the actual email
from one of your inbox folders.  Do you really
want to do this?"

Expected Results:
Email removed from vFolder but still remains in
inbox

How often does this happen? 
Every time.

Additional Information:
While the vFolder documentation clearly indicates
how vFolders work, when you eventually find it, it
doesn't say anything in the glossary.  Thus after
reading the glossary I thought that vFolders were
COPIES of mail in other folders and when I deleted
everything in unmatched because I didn't care
about it, All my email was gone in Inbox.

OS Fedora Core 2
Comment 1 André Klapper 2005-02-09 17:51:53 UTC
adding "vfolders" keyword
Comment 2 André Klapper 2005-08-06 15:37:13 UTC
changing component to "Mailer" to get rid of the UI component, also reassigning
as discussed with nags... adding UI keyword.
Comment 3 Karsten Bräckelmann 2005-11-13 17:03:20 UTC
The mentioned warning dialog would be a safe way to remind the user and prevent
data loss. Agreed here, I think. Of course, this one needs a checkbox to never
see it again.

Anyway, the "Expected Result" is just plain wrong. This is obvious from your own
Additional Information. The expected result is the way it is meant to work, the
way it is explained in the docs. This is a "search", so the expected result is
to remove the mail.
Comment 4 Tom Harris 2005-11-16 19:30:48 UTC
This certainly needs something done about it. Right now behaviour is incosistent
with no explanation for users: if I delete a vFolder, it deletes the folder but
not the emails in it, but if I delete an email in a vFolder it is deleted.
Though this is correct - according to the fact that the vFolder is a search not
a folder, whereas the email IS an email - this should be made clearer to users.
Comment 5 Milan Crha 2007-10-12 13:45:03 UTC
Created attachment 97120 [details] [review]
proposed evo patch

for evolution;
Comment 6 Srinivasa Ragavan 2007-11-05 07:44:20 UTC
Milan, Nice. But I think we should have 'Don't ask this again' sort of check box also. Otherwise it could be annoying.
Comment 7 Milan Crha 2007-11-05 09:40:23 UTC
Are you sure, srini? In this particular case, it is better to annoy them, because of keep data, I think. But probably I'm wrong. What do you think?
Comment 8 Srinivasa Ragavan 2007-11-05 18:04:55 UTC
Milan, users may not know this, so it is fine to popup for the first time. If the user knows that well and it does that repeatedly is what is annoying. So for them, 'Dont ask me again' will help.
Comment 9 Milan Crha 2007-11-06 12:24:53 UTC
Created attachment 98653 [details] [review]
proposed evo patch ][

for evolution;

here we go, new key for that is "/apps/evolution/mail/prompts/delete_in_vfolder".
Comment 10 Srinivasa Ragavan 2007-11-09 14:48:52 UTC
Looks fine to me. Test and commit.
Comment 11 Milan Crha 2007-11-12 10:45:31 UTC
Committed to trunk. Committed revision 34523.
Comment 12 André Klapper 2007-11-12 23:35:38 UTC
NO.

#: ../mail/mail.error.xml.h:46
"Delete messages in virtual folder?"

#: ../mail/mail.error.xml.h:45
"Delete messages in virtual folder "{0}"?"

#: ../mail/mail.error.xml.h:125
"Warning deleting email from a virtual folder will delete the actual email 
from one of your Inbox folders.\n
Do you really want to do this?"

"Warning deleting email" contains two errors. it should be "Warning:" and either "emails" or "mail" (and corresponding to the second "email" string.
and we don't have "virtual folders", we call it "Search folder" EVERYWHERE else? how much do we want to confuse the user?
and it is NOT in Inbox folders! i have search folders on non-inbox folders too!
Comment 13 Milan Crha 2007-11-13 11:29:00 UTC
Created attachment 99020 [details] [review]
proposed evo patch ]I[

for evolution;

ok, ok, I'm not good in writing texts, you know. This is better, I hope :)
Comment 14 André Klapper 2007-11-13 12:21:56 UTC
1) keep "Delete messages" i would say.
2)
"Deleting message from a Search Folder will delete the actual message from one of your local or remote folder."
"deleting message" does not work, must be "messageS". also "one of your local or remote folderS".
Comment 15 Milan Crha 2007-11-13 13:14:04 UTC
Created attachment 99025 [details] [review]
proposed evo patch IV

for evolution;

Maybe better now?
Comment 16 André Klapper 2007-11-13 15:41:14 UTC
yepp.
Comment 17 Milan Crha 2007-11-13 17:46:25 UTC
Committed to trunk. Committed revision 34529.
Comment 18 Milan Crha 2007-12-06 13:38:08 UTC
My fault that the checkbox is not saved properly, so fix for this is here...
Comment 19 Milan Crha 2007-12-06 13:40:07 UTC
Created attachment 100381 [details] [review]
proposed evo patch

for evolution;

I tested it wrong. The check is hidden in gtk_alignment, so the function didn't find it properly, so didn't save the state. Fixed here.
Comment 20 Srinivasa Ragavan 2007-12-06 13:44:01 UTC
didn't test it. but looks good to me. Test and commit.
Comment 21 Milan Crha 2007-12-06 13:54:00 UTC
Committed to trunk. Committed revision 34660.

I'm sorry for such obvious thing... huh...