After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 263172 - Contact Editor save/close logic (should_close flag)
Contact Editor save/close logic (should_close flag)
Status: RESOLVED OBSOLETE
Product: evolution
Classification: Applications
Component: Contacts
3.2.x (obsolete)
Other All
: Low normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
evolution[cleanup] evolution[compeditor]
Depends on:
Blocks: 327508 327510
 
 
Reported: 2004-08-16 19:12 UTC by Hans Petter Jansson
Modified: 2021-05-19 12:12 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Hans Petter Jansson 2004-08-16 19:12:06 UTC
The contact editor's save/close logic is a bit off. Currently we have a
should_close flag that's being passed around in context structs to
callbacks, which cannot be accessed by other calls. The fix is to move the
should_close flag to the editor struct proper.
Comment 1 Sivaiah 2005-03-28 18:04:58 UTC
this is bascailly a code cleanup
Comment 2 André Klapper 2006-01-09 02:20:33 UTC
at least retargetting from 2.2 to 2.5
Comment 3 André Klapper 2006-03-05 01:22:16 UTC
changing target milestone from 2.5 to future. sorry, too many bugs, too less time.
Comment 4 André Klapper 2012-06-17 12:05:53 UTC
gboolean should_close is part of the EditorCloseStruct in addresbook/gui/contact-editor/e-contact-editor.c, still does not look fully clean.
Bumping version info.
Comment 5 André Klapper 2021-05-19 12:12:17 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. 
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/Community/GettingInTouch/BugReportingGuidelines
and create a new bug report ticket at
  https://gitlab.gnome.org/GNOME/evolution/-/issues/

Thank you for your understanding and your help.