GNOME Bugzilla – Bug 262226
Inconsistent "all day" behaviour of appointment editor
Last modified: 2007-08-20 09:48:37 UTC
The calendar component behaves differently depending on which view you have selected. What I do is the following: Right click and select "New Appointment...". The following is happening: * Day View / Work Week View The appointment editor opens with start time set to the current time. "Show time as busy" is checked. (Okay) * Week View / Month View The appoinement editor opens in "All Day Event" mode. Start time is set to the current day, "Show time as busy" is unchecked, "All day event" is checked. (Not Okay) * List View No context menu available. The same thing applies to "New > Appointment" from the toolbar, "File > New > Appointment" from the menu bar, and Ctrl+N as keyboard shortcut. All these lead to "New Appointment" when Day and Work Week views are active, but to "New All Day Event" in Week, Month, and List view. As a side effect, both in Week view and in Month view you have no chance to enter an appointment without checking/unchecking two check boxes. Furthermore, the context menu entries "New Appointment..." and "New All Day Event" (which lacks the "..." by the way) behave exactly the same, making one of them obsolete in this context. Additionally, the check boxes move if you toggle "All day event" as the time input boxes get hidden. You have to regain orientation (and move the mouse cursor) if you hit the check box accidently. See #60645 for background.
This is historical, we won't fix this in 2.0.x, but we will in 2.1
still valid in evolution-2.1.5.0.200502091805-0.snap.ximian.10.1 please also take a look at the two date boxes moving everytime when enabling/disabling all-day-event checkbox (this is the last paragraph)!
updating version numbers
*** Bug 318779 has been marked as a duplicate of this bug. ***
can we please take a look at this for 2.6?
*** Bug 332386 has been marked as a duplicate of this bug. ***
It is purposefully done, as I see the code. I would prefer to leave it as it is.
I notice some usability issues still begging to be addressed here. But as Srini points out, week/month views defaulting to 'All day events' is deliberate and per user feedback.
okay, *if* this is purposefully done, what is the use of the "all day event" item in the new dropdown menu and the right-click context menu in the calendar then? this just does not make sense at all to me. *if* i want an all day event, i *choose* an all day event. consequently i'd say now: please remove "new all day event" in the week and month view.
OK I see the real bug. If you select NEW->Appointment it opens All day meeting. Ideally even the new has to say 24hour meeting. - Either fix that new button to show 24 hour icon or - make new open just new appointment.
i definitely prefer the latter option; the first one does not address the problem at all in my opinion, it only refers to that symbol when clicking the "new" button. it totally misses evolution's misbehaviour that i get an all-day-event-editor when choosing "new all day event" as well as "new event".
*** Bug 358191 has been marked as a duplicate of this bug. ***
Created attachment 91966 [details] [review] proposed patch for evolution; When don't need all_day event and there are 24 hours selected, then change start/end to actual time in selected day, instead of setting all_day event to TRUE. It will round starting time to the nearest time based on selected time division.
2.11.90 still has this. New Appointment should have a start time, and end time, and a duration. All Day Event should be just that. Using New Appointment to create an All Day Event is both confusing and inaccurate. The view should not affect what is created. This would be similar to changing the way contacts are added. Would it make sense to have one method of adding a contact allow you to add a phone number and another method NOT to allow it? Or to make you change a toggle after you click NEW? Of course not. Adding a contact is adding a contact. Thus, please be consistent with the distinction of adding an Appointment vs adding an All Day Event. I always use monthly view because I don't have a lot of appointments. Yet, those I do have always have a start and end time. JM2C
Milan, Im not sure, what your patch is intended to do. I tried it, but it still creates ALL_DAY events, if I click new in month/week view. I would like to change it to create a normal appt.
Created attachment 93769 [details] [review] proposed evo patch for evolution; I did it better, this time. I also reverted changes from fix of bug #321741 to keep it more consistent. This time it acts in the same way regardless of creation method. (File->New->Appointment, right_click->New appointment, or double click - it creates now same appointment like chosen from menu.)
srag points me that this is not the way, so I'm rejecting last patch, adding here better one.
Created attachment 93776 [details] [review] proposed evo patch for evolution; I did it better now, I suppose. Notice: I fixed one critical warning within this patch (when no default_address is set), and also frees memory of this default_address when no longer needed, so it will not leak.
Milan, awesome work. Just one small stuff. When you do file->new or double-click on week/month view, it open new-appt. But, the time it select is current rounded-off time. I think it is good, when it does for the current day, but, it not nice, when it does for other days. For example after file->new, if I click All_day_appt toolbutton twice (enable and disable) it reverts back the time to 8:30, the day start time. I think to be consistent, in week/month if the day is not today, then stick to the day-start time. Other wise the patch looks really good. If you have a better suggestion, Im open for it
Created attachment 93965 [details] [review] proposed evo patch for evolution; ok, I did it as you wish. Also notice, when you "check"/"uncheck" all day event in editing dialog, then it forgets time duration too. But it's the question for dialog itself.
Milan, looks fine dude.
Committed to trunk. Committed revision 34043.