After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 258748 - Birthday events not entirely all day events
Birthday events not entirely all day events
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
1.5.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: Rodrigo Moya
Evolution QA team
: 260647 261057 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-05-20 09:00 UTC by Björn Torkelsson
Modified: 2013-09-10 14:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot at startup (15.94 KB, image/png)
2004-06-10 17:45 UTC, William Jon McCann
  Details
screenshot after clicking Clear button (12.72 KB, image/png)
2004-06-10 17:46 UTC, William Jon McCann
  Details
Patch with partial fix; this one removes the timezone from cdate_to_icaltime() (1.51 KB, patch)
2004-06-24 21:34 UTC, Federico Mena Quintero
none Details | Review

Description Björn Torkelsson 2004-05-20 09:00:30 UTC
Birthdays events (from Birthdays and aniversaries) shows up with a start
and end time in the calendar. In my case they starts at 02.00 and ends
24hrs later. I.e they are two hours off. When I open them in the editor
they are marked as all day events though.
Comment 1 Stian Jordet 2004-05-24 21:48:38 UTC
Same problem here. Obviously related to our timezone, and rather
annoying. Messes up the calendar quite badly :(
Comment 2 Lonnie Borntreger 2004-05-27 18:19:01 UTC
Possibly related (Rodrigo Moya thinks it's the same bug)...
My all day events look fine in all views except for the "Work Week"
view.  In that view, they show as running from 5pm to 5pm (which is
what all my Birthday and Anniversary entries do in all views).  My
timezone is PDT (America/Los_Angeles Daylight Savings).
Comment 3 Dave Malcolm 2004-06-01 15:47:15 UTC
Possibly duplicated here as well:
http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=124880
Comment 4 Eric Lambart 2004-06-02 22:48:30 UTC
I have this problem, but it is the same in ALL views.  I'm also in the 
5PM-5PM (US PDT time zone) club.

Even in the List View,  it shows all birthdays starting on the actual 
day, and ending the next--although for birthdays, unlike other (not 
all-day) events, it does not show a start/end TIME.
Comment 5 Keith Sharp 2004-06-03 08:16:31 UTC
I see this with every All Day Event, not just Birthdays and Anniversaries.

When I create an All Day Event it initially looks fine, but if I quit
evolution and then restart it spreads over two days as reported above.

Note, to get this I have to quit and restart.  Switching from Calendar
to Email and back does not generate this fault.
Comment 6 Keith Sharp 2004-06-03 09:40:52 UTC
More investigation: it only appears to affect Month view and Week
view.  All other views are ok.
Comment 7 William Jon McCann 2004-06-04 15:18:08 UTC
This seems similar to what we saw in the clock applet too.  The clock
applet now handles this birthday/all day case correctly.

http://bugzilla.gnome.org/show_bug.cgi?id=134931
Comment 8 Rodrigo Moya 2004-06-10 15:05:46 UTC
This should be fixed on CVS now
Comment 9 William Jon McCann 2004-06-10 17:42:21 UTC
I just did a make distclean; make and I'm still seeing it.

Something else odd too.  When I create a birthday event in my personal
calendar as an all day event it initially shows up as starting at the
wrong time too.  Then when I click on the Clear button in the search
bar it fixes itself.  I'll attach screenshots.
Comment 10 William Jon McCann 2004-06-10 17:45:42 UTC
Created attachment 43837 [details]
screenshot at startup
Comment 11 William Jon McCann 2004-06-10 17:46:15 UTC
Created attachment 43838 [details]
screenshot after clicking Clear button
Comment 12 Federico Mena Quintero 2004-06-24 18:48:49 UTC
*** bug 260647 has been marked as a duplicate of this bug. ***
Comment 13 Federico Mena Quintero 2004-06-24 21:33:17 UTC
Part of the problem is that e-cal-backend-contacts.c sets the timezone
of the components to UTC in cdate_to_icaltime().  The attached patch
fixes this --- all-day components like this should not have timezones
in their dates.

However, even with the patch I'm getting offset birthdays.  I don't
know if some other part of the code is overriding the empty timezone.
Comment 14 Federico Mena Quintero 2004-06-24 21:34:22 UTC
Created attachment 43897 [details] [review]
Patch with partial fix; this one removes the timezone from cdate_to_icaltime()
Comment 15 Rodrigo Moya 2004-07-05 15:57:45 UTC
*** bug 261057 has been marked as a duplicate of this bug. ***
Comment 16 Andrew Cowie 2004-07-08 00:04:47 UTC
FYI, Problem still present as of 1.5.9.2. In this case, I'm in
UTC+10+DST, so birthdays are showing up as 11am on target date until
11am next day. Shows up this way in all views.

For what it's worth: I suppose this *could* be useful if I was able to
clearly assign a timezone to [contacts/]birthdays. However, then you'd
need UI for "is this person where they normally are" and/or "I know
this person will be in Fiji for their birthday"... way too many cases.
If you keep it simple at single all-day-event that ignores timezone
(which I think is your intent) then it should be good to go.

AfC
Sydney
Comment 17 JP Rosevear 2004-07-14 02:28:56 UTC
Fixed.
Comment 18 Björn Torkelsson 2004-07-14 23:28:37 UTC
I still see it (for birthday events) on an evolution built on Jul 14
from anoncvs, thouch the Changelog entry says it should be fixed :-(
Comment 19 JP Rosevear 2004-07-16 21:18:01 UTC
Fixed for real this time (turned out to be two bugs).