After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 256540 - gpg details dialog has a single tab
gpg details dialog has a single tab
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.6.x (obsolete)
Other All
: Normal minor
: Future
Assigned To: Milan Crha
Evolution QA team
Depends on:
Blocks: 327508 327510
 
 
Reported: 2004-04-06 16:09 UTC by Ben Kahn
Modified: 2008-07-28 07:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed evo patch (3.57 KB, patch)
2008-07-11 13:18 UTC, Milan Crha
committed Details | Review

Description Ben Kahn 2004-04-06 16:09:03 UTC
Please fill in this template when reporting a bug, unless you know what you
are doing.
Description of Problem:
gpg details dialog has a single tab

Steps to reproduce the problem:
1. read a message signed using gpg
2. click on the lock (or broken lock) icon

Actual Results:
dialog appears with a single "details" tab.

Expected Results:
dialog appears with no visible tab

How often does this happen? 
everytime

Additional Information:
tabs are for organizing information.  A single tab is useless.
Comment 1 Ben Kahn 2004-04-26 20:24:55 UTC
Ugh.  Why is the target milestone so far away?  Is this problem so
hard to fix?  Seems like a simple one liner.  (Or is it just so rare
to see?)
Comment 2 JP Rosevear 2004-10-05 17:49:53 UTC
I think this dialog can have two tabs.
Comment 3 Ben Kahn 2004-10-05 18:17:39 UTC
What would the two tabs contain?
Comment 4 Tommi Komulainen 2005-01-09 18:43:31 UTC
Why not only show the tabs if there's more than one?
Comment 5 Ben Kahn 2005-01-09 22:32:28 UTC
Right...  That's the gnome interface guidelines.  But the previous
question was: why not use two tabs?  I wanted to know what would be
displayed in each tab.
Comment 6 André Klapper 2005-02-07 15:08:28 UTC
still one tab, at least it would be nice to show the key id or sth
like that, see bug 268414...
Comment 7 André Klapper 2005-03-23 16:50:20 UTC
still valid in evolution-2.2.0.0.200503210410-0.snap.ximian.10.1,
retargetting to 2.3.
if we only had a "hig" keyword... ;-)
Comment 8 André Klapper 2005-07-19 18:16:08 UTC
changing component to "Mailer" to get rid of the UI component, also reassigning
as discussed with nags... adding UI keyword.
Comment 9 André Klapper 2005-07-19 18:16:23 UTC
changing component to "Mailer" to get rid of the UI component, also reassigning
as discussed with nags... adding UI keyword.
Comment 10 André Klapper 2006-01-09 02:15:54 UTC
at least retargetting from 2.3 to 2.5
Comment 11 André Klapper 2006-03-22 01:29:42 UTC
removing old 2.5 target milestone and retargetting to future - sorry.
Comment 12 Gilles Dartiguelongue 2007-04-05 21:28:11 UTC
should probably look at gnome-terminal or epiphany sources to see how the tab on/off thing works.
Comment 13 Matthew Barnes 2008-03-11 00:27:14 UTC
Bumping version to a stable release.
Comment 14 Milan Crha 2008-07-11 13:18:04 UTC
Created attachment 114386 [details] [review]
proposed evo patch

for evolution;

Do not use only one tab there. Actually, I removed the GtkNotebook completely, there were two tabs, Summary and Details, but the design has been changed and
it was used only one of them. Thus no need to have there a GtkNotebook at all.

The other thing is that the improvement form the other side, would be done as well, but what to write on the summary tab? And have a special tab for Signer and Encrypter?
Comment 15 Srinivasa Ragavan 2008-07-27 18:51:31 UTC
(In reply to comment #14)
> Created an attachment (id=114386) [edit]
> proposed evo patch
> 
> for evolution;
> 
> Do not use only one tab there. Actually, I removed the GtkNotebook completely,
> there were two tabs, Summary and Details, but the design has been changed and
> it was used only one of them. Thus no need to have there a GtkNotebook at all.
> 

Commit and announce UI change.

> The other thing is that the improvement form the other side, would be done as
> well, but what to write on the summary tab? And have a special tab for Signer
> and Encrypter?
> 

Didn't get you question.
Comment 16 Milan Crha 2008-07-28 07:05:39 UTC
Committed to trunk. Committed revision 35847.

The question was just about two possible ways how to solve this. One was by removing GtkNotebook completely, the other was to populate the second tab too.
Never mind, I chose the first option.