After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 246356 - Can't change the color of the text with keyboard.
Can't change the color of the text with keyboard.
Status: RESOLVED FIXED
Product: GtkHtml
Classification: Other
Component: html-editor-control
unspecified
Other All
: Normal normal
: Future
Assigned To: mengjie yu
Evolution QA team
Depends on:
Blocks: 242070 271192
 
 
Reported: 2003-07-15 03:19 UTC by Jessie Li
Modified: 2005-01-21 07:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for gal (4.79 KB, patch)
2004-02-15 12:20 UTC, Eric Zhao
none Details | Review
Here is the patch. (1.67 KB, patch)
2005-01-20 12:22 UTC, mengjie yu
none Details | Review

Description Jessie Li 2003-07-15 03:19:12 UTC
Steps to reproduce the problem:
1. Start evolution.
2. Click New Mail Message.
3. Input text, highlight the text.
4. Press Alt+m, then press t to open Text Properties dialog.
5. Press Tab key to put focus on the Color item.
6. Press Up, space, enter key to open the color picker.

Actual Results:
The color picker can't be opened.

Expected Results:
There should one way to open the color picker to change the color.

How often does this happen? 
always.
Comment 1 yuedong du 2003-07-30 06:45:08 UTC
actually a gal bug. In gal widget color_combo.
Comment 2 Radek Doulik 2004-01-08 11:33:53 UTC
gal dependency was just removed, it needs to be fixed in gtkhtml
(gi-*.c files in editor component).
Comment 3 Eric Zhao 2004-02-15 12:20:51 UTC
Created attachment 43319 [details] [review]
patch for gal
Comment 4 Eric Zhao 2004-02-15 12:21:33 UTC
This patch has also been submitted to the list.
Comment 5 Gerardo Marin 2004-04-12 05:32:35 UTC
The patch is wrong if you take note of the files to be edited 
mentioned by Radek
Comment 6 Eric Zhao 2004-04-19 15:34:35 UTC
As it is mentioned by Radek, gi-*.c files in editor component of
gtkhtml provide the same functions (gal_combo_box_*) as gal did, and
the result is that both libgnome-gtkhtml-editor-3.1.so and
libgal-2.2.so.0 provide the same functions gal_combo_box_*. But when
evolution startup, the functions gal_combo_box_*  in libgal-2.2.so.0
will be used.
                                                                     
          
So this patch can fix the evolution's problem, but if we want to use
gtkhtml module without gal, then some additional merge is needed.
                                                                     
          
Still I have a question, since this widget(gal_combo_box) is provided
by gtkhtml, why does it still exist in gal?  If the existing in gal is
necessary, why do we have to maintain a copy of similar code in
gtkhtml, just for the removing of gal dependency?
Comment 7 Harry Lu 2005-01-12 11:46:35 UTC
Now it is a gtkhtml's gi-color-combo bug.
Comment 8 mengjie yu 2005-01-20 12:22:29 UTC
Created attachment 44619 [details] [review]
Here is the patch.
Comment 9 mengjie yu 2005-01-21 07:31:05 UTC
Patch commited into CVS Head.