After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 246235 - Add Virtual Folder Rule dialog - UI suggestions
Add Virtual Folder Rule dialog - UI suggestions
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.6.x (obsolete)
Other other
: Normal normal
: ---
Assigned To: Evolution Product Design Team
Evolution QA team
Depends on:
Blocks: 246224
 
 
Reported: 2003-07-13 21:50 UTC by Eugene O'Connor
Modified: 2013-09-13 00:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Changed layout (10.05 KB, patch)
2006-02-03 04:56 UTC, Johnny Jacob
committed Details | Review
screenshot of the new UI (40.13 KB, image/png)
2006-07-11 17:24 UTC, André Klapper
  Details

Description Eugene O'Connor 2003-07-13 21:50:59 UTC
Add Virtual Folder Rule dialog - To open, choose Tools > Virtual Folder 
Editor, click Add. 

1. Would it be more logical to put the Add button and Execute actions drop-
down list below the table of criteria? Would this make more sense from a 
usability point of view?
2. It might make the functionality of the vFolder Sources group clearer if 
it was like this:

|---Sources for Virtual Folder------------------------------|
|                                                           |
|   (*) All local folders                                   |
|   ( ) All active remote folders                           |
|   ( ) All local folders and active remote folders         |
|   ( ) Specific folders          [Select Folder]           |
|   ----------------------------------------------------    |
|   |                                                  |    |
|   |                                                  |    |
|   |                                                  |    |
|   ----------------------------------------------------    |
|-----------------------------------------------------------|

This bug blocks bug 246224.
Comment 1 Anna Marie Dirks 2003-09-18 16:28:21 UTC
For #1, can you explain your logic a bit? For #2, I agree with you. 

Thanks! 

Anna
Comment 2 Eugene O'Connor 2003-10-08 12:01:26 UTC
My logic for #1:

Users already have one row of what the Add button gives them when they
open the dialog. I am trying to follow a principle of moving from
simple to complex down the dialog. That is, don't make the user need
to figure out the relationship between these three elements until they
need to. It may be that they will not need to use the Add button at
all, so why confuse the path to the rule row with the Add button?
Comment 3 André Klapper 2006-01-09 02:13:13 UTC
at least retargetting from 2.3 to 2.5
Comment 4 Johnny Jacob 2006-02-03 04:56:55 UTC
Created attachment 58630 [details] [review]
Changed layout
Comment 5 André Klapper 2006-02-27 23:43:10 UTC
did not happen in 2.5 timeframe, changing target milestone to 2.7 because we have a patch available.
not possible for 2.6 because of UI freeze though.
Comment 6 Srinivasa Ragavan 2006-07-11 16:10:36 UTC
I have reviewed it in 2.6 time frame. This was missed out. It can be committed to head.
Comment 7 André Klapper 2006-07-11 17:24:36 UTC
Created attachment 68780 [details]
screenshot of the new UI

"see the changes(TM)!"
Comment 8 André Klapper 2006-07-11 17:31:13 UTC
committed the patch to CVS HEAD after recompiling and some testing:
http://cvs.gnome.org/viewcvs/evolution/mail/em-vfolder-rule.c?r1=1.11&r2=1.12
http://cvs.gnome.org/viewcvs/evolution/mail/em-vfolder-rule.h?r1=1.1&r2=1.2
http://cvs.gnome.org/viewcvs/evolution/mail/mail-dialogs.glade?r1=1.7&r2=1.8

patch will be included in unstable evolution 2.7.5.
thanks to jony for providing and to srini for reviewing.

* UI Change Announcement Period disclaimer: sent email to gnome-doc-list and gnome-i18n. *