GNOME Bugzilla – Bug 246233
Inconsistent use of "Abc Editor" concept
Last modified: 2013-09-13 00:49:35 UTC
Do we need to use the following concepts: Virtual Folder >>Editor<< Saved Search >>Editor<< Filter >>Editor<< Or could we have: Tools > Virtual Folders Search > Saved Searches and Tools > Filters? If we go for the non-Editor approach, then we need to make the following change: 1. Menu item: s/Tools > Virtual Folder Editor/Tools > Virtual Folders This bug blocks bug 246224.
Sounds good (the s/Virtual Folder Editor/Virtual Folders bit.)
If we are removing the "Editor" concept, we'd also need to make the following change: 2. Dialog title: s/Search Editor/Searches (Search > Edit Saved Searches)
in evolution-2.1.4.0.200502011251-0.snap.ximian.10.1 this is - "tools | virtual folder editor..." with window title "vFolders" -----> should "Virtual folders" be kept or should i rename it to "vFolders..." - "search | edit saved searches..." with window title "search editor" - "tools | filters..." with window title "filters" ...so it's still inconsistent! moving target to 2.3 as discussed by dobey on irc because dobey's context menu patches aren't in yet and this one would depend on it...
little change due to solving bug 268137: evolution-2.1.4.0.200502040900-0.snap.ximian.10.1: "Tools | Filters..." with window title "Filters" "Tools | vFolder Editor..." with window title "vFolders" "Search | Edit saved searches..." with window title "Search Editor"
Created attachment 56092 [details] [review] Proposed patch for Bug 246233 This patch changes "Search Editor" title to "Searches". vFolders is already modified to "Search Folders" and similarly Filters.
Adding srag to the cc' list for his comments.
looks fine to commit. I'll commit it.
Committed to Head.