After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 240317 - RFE: Allow searching in subscribe dialog
RFE: Allow searching in subscribe dialog
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
unspecified
Other All
: Normal normal
: Future
Assigned To: evolution-mail-maintainers
Evolution QA team
: 315742 496956 516594 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-03-26 16:06 UTC by Jeffrey Stedfast
Modified: 2010-06-28 11:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
eds patch (4.90 KB, patch)
2010-05-06 15:17 UTC, Milan Crha
committed Details | Review
evo patch (33.67 KB, patch)
2010-05-06 15:22 UTC, Milan Crha
committed Details | Review

Description Jeffrey Stedfast 2003-03-26 16:06:06 UTC
Allow the ability to limit the folders shown by entering a search string
Comment 1 Karsten Bräckelmann 2006-01-23 18:38:11 UTC
*** Bug 315742 has been marked as a duplicate of this bug. ***
Comment 2 Karsten Bräckelmann 2006-01-23 18:40:53 UTC
Since Evo supports NNTP this is a missing feature and thus a bug, rather than an enhancement.
Comment 3 Matthew Barnes 2008-12-03 02:28:31 UTC
*** Bug 496956 has been marked as a duplicate of this bug. ***
Comment 4 Milan Crha 2010-05-06 15:17:02 UTC
Created attachment 160446 [details] [review]
eds patch

for evolution-data-server;

This makes NNTP provider slightly quicker with respect of full folder hierarchy filling, it cut the time from more than 5 seconds to 1/4 of a second for me. It also doesn't generate a flat list, but a folder hierarchy for the subscription dialog.
Comment 5 Milan Crha 2010-05-06 15:22:35 UTC
Created attachment 160447 [details] [review]
evo patch

for evolution;

- search ability (thus fetching whole folder hierarchy)
- icons beside folder names
- no checkboxes on unselectable nodes of the tree
- expand all & collapse all buttons added
- expands nodes which are subscribed on fetch by default
Comment 6 Milan Crha 2010-05-06 15:24:32 UTC
Created commit a8d9fc6 in eds master (2.31.2+)
Created commit 0b743a7 in evo master (2.31.2+)
Comment 7 Akhil Laddha 2010-06-23 05:32:56 UTC
*** Bug 516594 has been marked as a duplicate of this bug. ***
Comment 8 David Woodhouse 2010-06-26 15:06:00 UTC
Hm, the eds side of this broke. When it creates a 'virtual' NOSELECT|CHILDREN folder to fill a gap in the hierarchy, it doesn't correctly insert that into the tree if it is a top-level folder (i.e. last == NULL).

Once you fix that bug, you end up with two identical copies of the tree-insertion code. I moved that out into a separate function:

http://git.infradead.org/users/dwmw2/evolution-data-server.git/commitdiff/85265349

Now I just need to work out why it's showing all folders as being empty, even after I watched the traffic as it fetched the posts....
Comment 9 Milan Crha 2010-06-28 10:00:43 UTC
Strange, it seemed to work fine for me. Anyway, please attach it here as a patch (though preferably in a new bug report), so it can be tracked properly. Thanks.
Comment 10 David Woodhouse 2010-06-28 11:19:00 UTC
I pushed the fix to master.