After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 239175 - the declaration of LAST_SIGNAL to a certain number should be changed
the declaration of LAST_SIGNAL to a certain number should be changed
Status: RESOLVED FIXED
Product: GAL
Classification: Deprecated
Component: ETable
trunk
Other All
: Normal enhancement
: 1.4.x
Assigned To: Mike Kestner
Evolution QA team
Depends on:
Blocks: 239034
 
 
Reported: 2003-03-06 07:49 UTC by philip zhao
Modified: 2003-03-12 17:33 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Description philip zhao 2003-03-06 07:49:06 UTC 
~/gal/gal/widgets/e-option-menu.c
has these lines:

enum{
   LAST_SIGNAL
};

static guint signals [LAST_SIGNAL] = { 0, } //error here!

When we build gal using Forte, it will error at that line. Forte won't see
LAST_SIGNAL as 0 or 1 defined in enum.
We should regular the code here.
Comment 1 Henry Jia 2003-03-12 12:54:18 UTC 
Since LAST_SIGNAL is equal to 0, the array definition of
signals[LAST_SIGNAL] is not correct. The member number should be
LAST_SIGNAL+1.
Comment 2 Mike Kestner 2003-03-12 17:33:45 UTC 
LAST_SIGNAL is a placeholder enum that is used like a "count" value
extensively in gal.  In this case, since there are no signals for this
object, there is no need for a signals[] or the enum.

I have committed a patch to remove them to CVS trunk. Please advise if
you need this patch on the 1-2-branch and I will backport it.