GNOME Bugzilla – Bug 234354
Switching folders while advanced search is opened
Last modified: 2008-07-09 16:33:43 UTC
Please fill in this template when reporting a bug, unless you know what you are doing. Description of Problem: You should not be able to change the folder you are currently looking at when an advanced search is open. Steps to reproduce the problem: 1. Go to Contacts 2. Tools->Advanced Search and leave open 3. Click on Inbox (either in shortcuts bar or folders bar) 4. Run search Actual Results: Search is run on Contacts, but the view isn't changed to Contacts after running search Expected Results: Either: - switch back to Contacts (which to me would look kinda weird) - not allow the user to switch from Contacts when advanced search is opened until advanced search is closed (better choice to me) How often does this happen? always Additional Information: This is should not specific to Contacts
still in evolution-2.1.5.0.200502091805-0.snap.ximian.10.1
Making the dialog modal is easy. Need a decision whether to do it.
Created attachment 44931 [details] [review] Here is the patch for this bug.
adding "patch" keyword
still valid in evolution-2.2.2.0.200504141611-0.snap.ximian.10.1, retargetting to 2.3.
I think going back to contacts to see the search results is fine. Srini, any comments?
mengji yu, part of the bug is valid. And a part of it is invalid IMHO.When you give a normal filter like starts with/ contains, then the search bar has the filter indicating that the filter is in place. In case of the Advanced search, therz no indication of a filter in place apart from the menu being changed to "Advanced...". IMHO, the real fix is that the rule name has to be in place to indicate that the advanced filter rule FOO is in place. Making it modal, will hide the issue. Also its not a good idea to have a modal dialog in this case, its not a fatal error or something that need the immediate attention of the user. Im marking the patch absolute
Apologies for any spam... cc'ing usability-maint on all Evolution usability bugs. Filter on EVO-USABILITY-SPAM to ignore.
changing target milestone from 2.5 to future. sorry, too many bugs, too less time.
This is somehow obsolete. I cannot change the view behind the Advanced Search dialog, thus this is fixed from my point of view. When looking into changes and the above patch, then this revision shows the proper change in 2003: http://svn.gnome.org/viewvc/evolution?view=revision&revision=20375 but the patch above is in address book source tree, in folder which doesn't exist any more. I guess the search bar has been merged to be same in all components, which solved this as a side-effect. Thus marking as fixed.