After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 229244 - Re-ordering email addresses in contact list editor
Re-ordering email addresses in contact list editor
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Contacts
2.4.x (obsolete)
Other All
: Normal enhancement
: Future
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2002-08-21 15:21 UTC by Laurent Bonnaud
Modified: 2011-05-27 17:22 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
Propsed patch (14.09 KB, patch)
2011-05-26 12:10 UTC, Dan Vrátil
committed Details | Review

Description Laurent Bonnaud 2002-08-21 15:21:56 UTC
Description of Problem:

In the contact list editor I would like to be able
to change the order of email addresses after
entering them.

Steps to reproduce the problem:
1. create a contact list with a least 2 email
addresses
2. try to change the order of the 2 addresses
Comment 1 André Klapper 2004-07-31 13:44:57 UTC
evolution1.5-1.5.91.0.200407250730-0.snap.ximian.8.1:
in the new contact editor, contact's email addresses will be displayed 
in the order "work, home, others" in the contact preview in the list 
view.
when i change work|home|other of the email addresses by using the 
dropdown menu the order of the email addresses displayed in the 
contact preview in the list view does not change.
so this is still not possible. :-(
Comment 2 Chris Toshok 2004-08-27 16:37:11 UTC
he's talking about reordering the email addresses in the contact list
editor, not in the contact editor or in the list view.

however, this is still valid in 1.5
Comment 3 Sushma Rai 2005-08-23 07:07:50 UTC
Laurent,
How does re-ordering the email ids help? I wanted to know in what scenario
it is useful?

Are you looking for an option to sort the sort the enries?

Comment 4 Laurent Bonnaud 2005-08-23 16:56:23 UTC
When I create a contact list, I may temporarily forget an important person and
only add it as an afterthought.  When this person receives my message it may be
offended to see its name at the end of the list whereas it plays a central role
in the list of people.

Furthermore there is a terminology problem: if the contact list cannot be
reordered, then it should be called a "contact set" :>.
Comment 5 Laurent Bonnaud 2005-08-23 16:58:29 UTC
Needed info provided.
Comment 6 Sushma Rai 2005-08-25 05:52:37 UTC
I think we can sort it on names by default and 
allown drag and drop between the members, though 
I am not very sure about implementation issues.
Comment 7 Laurent Bonnaud 2005-08-25 15:38:16 UTC
Drag and drop is fine, but it would be more consistent to use an UI similar to
the  filters dialog box (with up and down arrows).  Perhaps even some code could
be shared ?
Comment 8 André Klapper 2005-09-15 12:50:24 UTC
still missing in 2.4.0, retargetting from 2.3 to 2.5.
Comment 9 André Klapper 2006-03-22 01:29:30 UTC
removing old 2.5 target milestone and retargetting to future - sorry.
Comment 10 Dan Vrátil 2011-05-26 12:10:52 UTC
Created attachment 188658 [details] [review]
Propsed patch

This patch adds Top, Up, Down and Bottom buttons to Contact List editor to enable reordering of contacts in list.

Additionally, when removing an item from the list, the item below the removed one is automatically selected.
Comment 11 Matthew Barnes 2011-05-26 12:20:52 UTC
Would be good to enable drag-and-drop reordering in the tree view as well.  Might be as simple as calling gtk_tree_view_set_reorderable(), and might even obviate the need for buttons.
Comment 12 Dan Vrátil 2011-05-27 07:15:42 UTC
Gtk documentation says that reordable treeview cannot accept any other drag&drop events, but the Contact List already implements dragging contacts from address book. On the other hand, it is really difficult to use, because the dialog is covered by Evo window when you click a contact in address book to drag it and actually starting the drag in address book requires some magical double click, which 1) does not always work and 2) opens the contact editor as well, so dropping this feature from the Contact List editor wouldn't probably do much harm, but I'll let this decision to you.

Finally, even if it was implemented, I'd still keep the Up/Down buttons for the sake of consistency with other dialogs and remove them only when all other dialogs would implement reordering by drag&drop (and then dropping the buttons from all dialogs at once).
Comment 13 Milan Crha 2011-05-27 16:39:32 UTC
I had a little chat with Matthew and we decided to finish this bug with buttons "only", and open a new bug with a request for drag&drop reordering support in the Contact list editor, Message filters and Saved searches dialog, where is very similar functionality.
Comment 14 Milan Crha 2011-05-27 17:14:45 UTC
Created commit bb20ede in evo master (3.1.2+)
Comment 15 Milan Crha 2011-05-27 17:22:02 UTC
New bug entered, as promised in comment #13, is bug #651270.