After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 222423 - Support Face headers
Support Face headers
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: BugBuddyBugs
2.24.x (obsolete)
Other All
: Normal enhancement
: ---
Assigned To: Evolution Triage Team
Evolution QA team
evolution[eplugin]
Depends on:
Blocks:
 
 
Reported: 2002-03-25 14:31 UTC by Nick Brown
Modified: 2011-03-09 10:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Broken patch from debian evolution 2.2 implmenting X-Face support (4.29 KB, patch)
2006-01-16 07:06 UTC, Paul Wise
rejected Details | Review
Display preview of selected image below the button (1.28 KB, patch)
2011-02-02 14:44 UTC, Dan Vrátil
committed Details | Review

Description Nick Brown 2002-03-25 14:31:00 UTC
Description of Problem:

Mailer such as Exmh and Emacs Mailer have 
support for X-Face: mail headers.
the header is a small icon. (often the persons 
face). It would great to see Evolution support 
this header field.

Steps to reproduce the problem:
1. 
2. 
3. 

Actual Results:


Expected Results:


How often does this happen? 


Additional Information:

the best source of further information, 
including libiaries and utiliites is;

ftp://ftp.cs.indiana.edu/pub/faces/index.html
Comment 1 Gerardo Marin 2002-04-24 02:52:34 UTC
Patches / volunteers accepted :)
Comment 2 Not Zed 2002-07-03 03:36:26 UTC
setting milestone for contrib, an ideal contribution idea.
Comment 3 André Klapper 2005-05-18 00:13:55 UTC
adding eplugin keyword
Comment 4 Not Zed 2005-05-19 04:30:20 UTC
like bug 274405, this also needs the ability to plugin to the message headers
Comment 5 Not Zed 2005-05-19 06:18:04 UTC
this can now be done, using the x-evolution/message/rfc822 pseudo mime-type for
a format handler
Comment 6 Paul Wise 2006-01-16 07:06:48 UTC
Created attachment 57454 [details] [review]
Broken patch from debian evolution 2.2 implmenting X-Face support

I've attached a patch from the debian package for evolution 2.2 that implements Face and X-Face support. Only problem is that it doesn't seem to work with evolution 2.4 and compface 1.5.2:

http://bugs.debian.org/347702
http://bugs.debian.org/347528
Comment 7 Jeffrey Stedfast 2006-02-07 16:21:11 UTC
the debian XFace patch has always been broken, I remember getting a number of complaints about it "back in the day" when debian first introduced it into their packages.

IMHO XFace is a broken idea anyway that only few if any "hackeresque types" would even use. (X-Face looks fugly and the common user has no clue what it even is nor have access to it via any other mailer they or the people they communicate with use)

I think this would best be implemented as a plugin and not part of the base Evolution sources, if implemented at all.

Anyways... this particular patch is rejected (due to above explanation and also because it is broken).
Comment 8 Jeffrey Stedfast 2007-01-21 20:08:36 UTC
this should be implemented as an e-plugin if it gets implemented at all.
Comment 9 Nick Brown 2007-01-22 18:32:35 UTC
As well as the X-Face: header is there is also the Face: header.
While X-Face: is a 48x48 black and white image, Face: is a 48x48 PNG image.

Support for the Face: header seems to be integrated into several mailers, including kmail and thunderbird.

Details here;
http://quimby.gnus.org/circus/face/
Comment 10 Sankar P 2007-08-22 11:59:22 UTC
I've added a plugin called Face which is aimed at doing this. Though it is experimental it should work fine, I guess. Not tested very much. Will have to test it and mark this bug resolved if it works well.

Will be available from 2.11.X
Comment 11 millerp 2008-03-27 01:44:23 UTC
I'm using evolution 2.22.0

There doesn't seem to be any support in Edit|Preferences for automagically adding the Face to all outgoing email.

There doesn't seem to be any support for copying the face seen in the message window into the Contact details for the sender.
Comment 12 Gilles Dartiguelongue 2009-02-24 16:50:45 UTC
X-Face in mail preview and mail view works fine, didn't test sending though.
Comment 13 Akhil Laddha 2009-12-08 11:57:42 UTC
IMHO, we should close this bug and handle face plugin bugs separately.
Comment 14 Dan Vrátil 2011-02-02 14:44:15 UTC
Created attachment 179883 [details] [review]
Display preview of selected image below the button

Attached patch that will display preview of the image below the "Select image" button and removes conditions about image resolution and size from openfile dialog.
Comment 15 Matthew Barnes 2011-02-02 22:21:48 UTC
Cool, thanks Dan!  Didn't realize the scaling logic was already in there.

I made a few minor tweaks to the patch, nothing substantial.  I have some ideas on better integrating this in the composer window, such that it appears as a header underneath Subject and we can remove its configuration tab in the Plugin Manager.

Something like:

    Subject: [___________________________________________________]

   [ Face: ] [ preview ]   [x] Use this picture in future messages
       ^     [  image  ]
       |
   file chooser button

(With a corresponding menu item under the View menu, so you can hide this.)

But I first have to write a nice extension system for composer header fields.

Anyway, I think this plugin is good enough now to promote out of "experimental" status for 2.91.90.
Comment 17 Miguel Sanjurjo 2011-03-06 16:27:04 UTC
(In reply to comment #10)
> I've added a plugin called Face which is aimed at doing this. Though it is
> experimental it should work fine, I guess. Not tested very much. Will have to
> test it and mark this bug resolved if it works well.
> 
> Will be available from 2.11.X

The included plugin handles the Face: header great, both for sending and receiving. What's the story with the X-Face: header? Is there an extra plugin for it?
Comment 18 Matthew Barnes 2011-03-06 17:31:59 UTC
I see no need for X-Face support.  The Face header supercedes it.
Comment 19 Miguel Sanjurjo 2011-03-09 10:14:59 UTC
I agree with you, but not everybody does. Some still use the X-Face: header and not the Face: header. This is why it would be useful to be able to see the X-Face: header from Evolution. Sending it is not necessary.