After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 216251 - Need Signature Editor and Randomizer
Need Signature Editor and Randomizer
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
pre-1.5 (obsolete)
Other All
: Normal enhancement
: ---
Assigned To: Radek Doulik
Evolution QA team
Depends on:
Blocks: 216547
 
 
Reported: 2001-11-29 22:34 UTC by Anna Marie Dirks
Modified: 2013-09-10 13:53 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement



Description Anna Marie Dirks 2001-11-29 22:34:34 UTC
Picture it: take the composer. Remove the From/To/CC/and Subject entries,
and add a "Signature Name" entry and a "Include in Random List?" (or
something) checkbutton. Voila!  Now you have a lovely, html-capable, and
ridiculously powerful signature editor. Combine this with a simple dialog
which lists all of the signatures and whether or not they should be
included in the set of 
randomized sigs, together with Add and Remove buttons, and Evolution would
have the best signature handling of any of the mail clients I surveyed. 

I created a glade file of these designs, and a screenshot of it is
available at: http://primates.ximian.com/~anna/evo11/sig-editor.html

I don't think this requires much hacking work at all.
Comment 1 trow 2001-12-06 23:27:34 UTC
For fun, I added a small hack to the composer that checks if the sig
file is executable and, if it is, executes it and uses the output as
the signature.

This isn't nearly as nice as the UI suggested here, but it does give
"power users" a way to have randomized sigs right away. :-)
Comment 2 Ettore Perazzoli 2001-12-07 18:36:51 UTC
Hm, I really don't like the composer to execute a file blindly like this.

Please take this out.  :-)
Comment 3 trow 2001-12-07 21:09:57 UTC
OK, but I suspect that the relatively small percentage of users who
want to have randomized/variable sigs would want to use the output of
a program rather than stuff from a canned list.  (I have no evidence
to back me up, of course... but I think that most people who have
mentioned randomized sigs on the mailing lists have explicitly talked
about wanting to execute a script or something.)

This doesn't mean that the list editor/randomizer as proposed by Anna
isn't a good idea.  I think they both can coexist.  I'd suggest
either:

(1) Adding an "execute" toggle button to the account setup page where
the sig files are specified.  We could then execute the sig file iff
"execute" is set and the file actually is executable.  This would be
very easy to implement.

(2) Leave the feature in there for "power users" by requiring a magic
environment variable to be set.  Something like
EVOLUTION_PLEASE_EXECUTE_MY_SIGNATURE_FILE, maybe? :-) 

(Also, if we do allow generated sigs, we should probably limit them to
N lines, where N is a sufficiently non-annoying integer.)
Comment 4 trow 2001-12-10 19:31:49 UTC
/me discovers bug 216066.
Comment 5 Radek Doulik 2002-03-06 22:42:22 UTC
it lives now in own branch and once I resolve remaining issues I am
going to merge it to head. it includes scripting and randomly selected
signature features ;-)
Comment 6 Ettore Perazzoli 2002-03-27 23:26:44 UTC
Since this is done, closing the bug.
Comment 7 Anna Marie Dirks 2002-03-27 23:30:41 UTC
Hmm. What is currently implemented is not quite finished. Radek and I
discussed which changes still need to be made...is it inappropriate to
reopen until those changes are fixed? I don't want them to be forgotten.
Comment 8 Radek Doulik 2002-03-29 21:43:20 UTC
Actualy I think I've made all changes we have discussed together
(signature name in editor, format switching in editor, plus something
more which I don't remember already ;) Another thing is that with new
config dialog, old code needs to be probably little updated. Did I
forgotten anything?