GNOME Bugzilla – Bug 207802
Drag from message list to same message list should not show "copy" icon
Last modified: 2013-09-10 14:04:26 UTC
Start dragging a message from the message list. If you hover around the same message list then no action cursor should be displayed; currently it shows the Copy action cursor.
how do you do this?
In the drag_motion handler... gtk_drag_status() passing zero as the action.
and how can you tell if it is the same message-list? everything I try fails. blah, I give up.
the patch i'm about to attach sort of addresses it. it makes the angle thing flicker like shit though, so i'm not committing it yet.
Created attachment 41400 [details] [review] fix?
reassigning to notzed since he has a possible fix
i dont know if that patch is right. to me it makes it visually much worse because of flicker. i dont know any otherway to change the behaviour.
someone make a decision
Yes, please. Ageing needinfos make me nervous.
Poke?
Since we are not requering info from end user but internally, I'm reopening this report
adding "patch" keyword
In ml_tree_drag_motion(), you should just need to add something like if (gtk_drag_get_source_widget (context) == tree) { gdk_drag_status (context, 0, time); return TRUE; }
reassigning stuff that has been assigned to notzed. goodbye, dude. :-/
should be an easy fix as described by federico... srini?
removing old target milestone.
Created attachment 67396 [details] [review] Fix Fixes a crash that happens when somebody drops on "On this computer" or other store names and also contains Federico's suggestion.
veerapuram, so can your patch be committed to cvs head (and also stable branch)?
(In reply to comment #13) > In ml_tree_drag_motion(), you should just need to add something like > > if (gtk_drag_get_source_widget (context) == tree) { > gdk_drag_status (context, 0, time); > return TRUE; > } For some reason (I Dont know) it is not the same, and the patch seems to have no effect. It still shows the same icon. Im trying with evolution-2.8 on SLED.
same here, patch seems to have no effect. :-(
Bumping version to a stable release.
Created attachment 114179 [details] [review] proposed evo patch for evolution; Here is updated Varadhan's patch. The reason why it didn't work was the fact that the source widget was some ECanvas inside the tree, thus checking for the children in the ETree helps here.
Milan, looks fine. commit to trunk. I haven't tested it[My code is badly broken atm, so just test and commit], but looks fine and logical.
Committed to trunk. Committed revision 35732.