After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 207802 - Drag from message list to same message list should not show "copy" icon
Drag from message list to same message list should not show "copy" icon
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.8.x (obsolete)
Other All
: Normal minor
: ---
Assigned To: Milan Crha
Evolution QA team
Depends on:
Blocks: 327508 327510
 
 
Reported: 2001-08-21 22:14 UTC by Federico Mena Quintero
Modified: 2013-09-10 14:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix? (3.79 KB, patch)
2002-08-07 05:19 UTC, Not Zed
none Details | Review
Fix (896 bytes, patch)
2006-06-15 10:10 UTC, Veerapuram Varadhan
needs-work Details | Review
proposed evo patch (2.08 KB, patch)
2008-07-08 13:26 UTC, Milan Crha
committed Details | Review

Description Federico Mena Quintero 2001-08-21 22:14:14 UTC
Start dragging a message from the message list.  If you hover around the
same message list then no action cursor should be displayed; currently it
shows the Copy action cursor.
Comment 1 Jeffrey Stedfast 2002-05-06 21:15:20 UTC
how do you do this?
Comment 2 Ettore Perazzoli 2002-07-23 18:51:59 UTC
In the drag_motion handler...  gtk_drag_status() passing zero as the
action.
Comment 3 Jeffrey Stedfast 2002-07-25 23:30:09 UTC
and how can you tell if it is the same message-list? everything I try
fails.

blah, I give up.
Comment 4 Not Zed 2002-08-07 05:18:18 UTC
the patch i'm about to attach sort of addresses it.

it makes the angle thing flicker like shit though, so i'm not
committing it yet.
Comment 5 Not Zed 2002-08-07 05:19:11 UTC
Created attachment 41400 [details] [review]
fix?
Comment 6 Jeffrey Stedfast 2002-08-08 22:06:39 UTC
reassigning to notzed since he has a possible fix
Comment 7 Not Zed 2002-09-10 12:16:23 UTC
i dont know if that patch is right.

to me it makes it visually much worse because of flicker.

i dont know any otherway to change the behaviour.
Comment 8 Not Zed 2002-09-18 05:30:16 UTC
someone make a decision
Comment 9 Gerardo Marin 2002-10-18 19:18:45 UTC
Yes, please.  Ageing needinfos make me nervous.
Comment 10 Gerardo Marin 2002-11-25 23:11:44 UTC
Poke?
Comment 11 Gerardo Marin 2003-01-06 23:49:04 UTC
Since we are not requering info from end user but internally, I'm
reopening this report
Comment 12 André Klapper 2005-03-05 14:49:18 UTC
adding "patch" keyword
Comment 13 Federico Mena Quintero 2005-03-07 18:40:26 UTC
In ml_tree_drag_motion(), you should just need to add something like

  if (gtk_drag_get_source_widget (context) == tree) {
      gdk_drag_status (context, 0, time);
      return TRUE;
  }
Comment 14 André Klapper 2005-11-25 00:11:48 UTC
reassigning stuff that has been assigned to notzed. goodbye, dude. :-/
Comment 15 André Klapper 2006-06-14 14:08:53 UTC
should be an easy fix as described by federico... srini?
Comment 16 André Klapper 2006-06-14 14:13:12 UTC
removing old target milestone.
Comment 17 Veerapuram Varadhan 2006-06-15 10:10:16 UTC
Created attachment 67396 [details] [review]
Fix

Fixes a crash that happens when somebody drops on "On this computer" or other store names and also contains Federico's suggestion.
Comment 18 André Klapper 2006-07-08 14:05:56 UTC
veerapuram, so can your patch be committed to cvs head (and also stable branch)?
Comment 19 Srinivasa Ragavan 2006-08-23 06:53:19 UTC
(In reply to comment #13)
> In ml_tree_drag_motion(), you should just need to add something like
> 
>   if (gtk_drag_get_source_widget (context) == tree) {
>       gdk_drag_status (context, 0, time);
>       return TRUE;
>   }

For some reason (I Dont know)  it is not the same, and the patch seems to have no effect. It still shows the same icon. Im trying with evolution-2.8 on SLED.

Comment 20 André Klapper 2006-08-23 07:48:44 UTC
same here, patch seems to have no effect. :-(
Comment 21 Matthew Barnes 2008-03-11 00:28:27 UTC
Bumping version to a stable release.
Comment 22 Milan Crha 2008-07-08 13:26:29 UTC
Created attachment 114179 [details] [review]
proposed evo patch

for evolution;

Here is updated Varadhan's patch. The reason why it didn't work was the fact that the source widget was some ECanvas inside the tree, thus checking for the children in the ETree helps here.
Comment 23 Srinivasa Ragavan 2008-07-08 21:18:41 UTC
Milan, looks fine. commit to trunk. I haven't tested it[My code is badly broken atm, so just test and commit], but looks fine and logical.
Comment 24 Milan Crha 2008-07-09 07:53:45 UTC
Committed to trunk. Committed revision 35732.