After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 207563 - Saving draft, then closing window still triggers "unsaved" dialog.
Saving draft, then closing window still triggers "unsaved" dialog.
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
pre-1.5 (obsolete)
Other other
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2001-08-18 05:42 UTC by Eric Lambart
Modified: 2001-08-21 17:44 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Eric Lambart 2001-08-18 05:42:59 UTC
Description of Problem:
Closing a compose window immediately (and not modifying it in any 
way!) after doing a File->Save Draft causes a window to pop up, saying 
the message has not been saved.  If you click [Save], the compose 
window will close nicely... but when you go and look in the Sent 
folder, there are now two copies saved!

Furthermore, every time you hit File->Save Draft it saves a new copy. I
suppose this could be, or at least be considered to be, a feature, as 
you one might want to save subsequent drafts separately to keep track 
of your revisions or something... but I'm not sure I can imagine that 
many people would want to do that.  I think it just creates more 
folder cleanup work (ugh).


How Reproducible:
10/10 tries

Steps to Reproduce:
1. Type some text in a message compose window
2. Select File->Save Draft
3. Attempt to close the window
4. Answer "Yes" to dialog box question

Actual Results:
Dialog appears with the text "This message has not been sent.  Do you wish to save your changes?"  and the options Yes, No, Cancel... but the message has already been saved.

Expected Results:
The dialog should only appear if changes have been made since the last time the draft message was saved.

Additional Information:
Snapshot build 0815
Comment 1 Eric Lambart 2001-08-18 06:03:17 UTC
Suggestion re the "Furthmore" section above: when a new draft is saved, mark the previous draft for deletion.  If anyone really cares about saving each revision of a particular message, let 'em go back and unhide and undelete the previous drafts.

You could do the same thing when a draft is re-opened; after all the old copy is really there, and even though neophytes might not find it if it's hidden, Evo's excellent crash recovery should safeguard the new revision of the message.

However, the ideal method, in my opinion, would be to track some sort of message ID that you surely already are generating for the folder; just make sure the open (or re-opened) compose window knows the ID of the original draft.  When a new revision is made, save over the old one.  Then there won't be a mess of stricken-out older revisions.
Comment 2 Jeffrey Stedfast 2001-08-19 18:59:48 UTC
fixed in CVS...
Comment 3 Dan Winship 2001-08-21 16:13:19 UTC
Um... what did you do exactly, Jeff? This is a duplicate of
bug 200948 basically, meaning it can't really be fixed until
bug 200966 is.
Comment 4 Jeffrey Stedfast 2001-08-21 17:44:30 UTC
I fixed this:

Steps to Reproduce:
 1. Type some text in a message compose window
 2. Select File->Save Draft
 3. Attempt to close the window
 4. Answer "Yes" to dialog box question

 Actual Results:
 Dialog appears with the text "This message has not been sent.  Do you
wish to save your changes?"  and the options Yes, No, Cancel... but
the message has already been saved.

 Expected Results:
 The dialog should only appear if changes have been made since the
last time the draft message was saved.

I didn't fix the "suggestion" he made later because I knew there was
another bug for it (I believe chema submitted it).