GNOME Bugzilla – Bug 172536
Last modified: 2014-08-30 05:00:49 UTC
This simplifies for UI builders, to be able to set all information on a
GtkAction through properties.
Currently most of this code lives in gtk_action_group_add_with_accel. This can
be refactored to be a property in a GtkAction.
Created attachment 45099 [details] [review]
Does this look like it does what you need, Johan ?
Thanks for looking at this Matthias.
Unfortunately I cannot get it to work properly. I suspect it might be because
the action is not attached to an action group when the accelerator property is set.
Test case follows.
Created attachment 45107 [details]
You have to set up the accel path of the action.
Of course, that's it! Sorry about that.
This patch and a small modification to the code that adds actions to action
groups is everything I need.
I have not commmitted the patch yet, since we found out in another bug that we
need to use gtk_accel_map_add_entry(), not change_entry() for setting the
accelerator. But then, only the very first time this property is set will have
any effect. Making it construct-only does not sound quite right either, though.
Moving off 2.8 API freeze until inspiration hits
Patch 45099 doesn't apply cleanly. Reviewing it would take a little while.
(Working on http://mail.gnome.org/archives/gtk-devel-list/2007-March/msg00148.html)
GtkAction has been deprecated