After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 171330 - The rule for POTFILES doesn't remove intltool tags
The rule for POTFILES doesn't remove intltool tags
Status: RESOLVED FIXED
Product: intltool
Classification: Deprecated
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: intltool maintainers
intltool maintainers
Depends on:
Blocks:
 
 
Reported: 2005-03-23 10:31 UTC by Stepan Kasal
Modified: 2005-07-21 15:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.46 KB, patch)
2005-03-23 10:31 UTC, Stepan Kasal 		accepted-commit_now Details | Review

Description Stepan Kasal 2005-03-23 10:31:01 UTC 
The rule for POTFILES contains 's/^\[.*\] +//'
this sed command has several flaws:
1) "+" is not part of BRE, so the regex matches only lines containing literal
plus sign!
2) we may not require space after ']', think of [encoding:...] tags.
3) '\[' is not part of POSIX BRE's, though it works in most environments.

Issue (3) also appears in intltool.m4.
Comment 1 Stepan Kasal 2005-03-23 10:31:47 UTC 
Created attachment 39125 [details] [review]
patch

This patches fixes all the mentioned issues.
Comment 2 Rodney Dawes 2005-06-10 19:59:15 UTC 
*** Bug 171328 has been marked as a duplicate of this bug. ***
Comment 3 Christian Persch 2005-07-13 13:38:30 UTC 
I'm running into this problem with epiphany and evince all the time. I've tested
the patch (attachment 39125 [details] [review]) and it fixes the problem. Can it be checked in
please? Thanks!
Comment 4 Danilo Segan 2005-07-21 11:32:00 UTC 
Go ahead and commit. Thanks for the patch, and sorry about the delay.
Comment 5 Stepan Kasal 2005-07-21 12:05:36 UTC 
Committed.  Thank for review.
Comment 6 Rodney Dawes 2005-07-21 15:07:26 UTC 
*** Bug 171328 has been marked as a duplicate of this bug. ***