After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 170324 - gnopernicus should keep more informations about the text content of focussed/watched object
gnopernicus should keep more informations about the text content of focussed/...
Status: RESOLVED WONTFIX
Product: gnopernicus
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: remus draica
remus draica
AP2
Depends on:
Blocks:
 
 
Reported: 2005-03-14 14:25 UTC by Oana Serb
Modified: 2008-08-22 20:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (only for text-delete events for single-line texts) (4.21 KB, patch)
2005-03-17 09:54 UTC, remus draica
none Details | Review
reworked patch (4.46 KB, patch)
2005-05-17 07:46 UTC, remus draica
none Details | Review

Description Oana Serb 2005-03-14 14:25:50 UTC
For more details, see discussions from bug #161271.
Comment 1 remus draica 2005-03-17 09:54:17 UTC
Created attachment 38834 [details] [review]
proposed patch (only for text-delete events for single-line texts)
Comment 2 korn 2005-05-12 21:36:37 UTC
Remus, in your patch above, in srl_event_compute_line(), you check 'if
(event->detail1)', but if not, you continue to use it (in the line two lines
later).  Wouldn't it be better to simply return if detail1 or detail2 are null,
and otherwise then continue with the rest of your logic?

Also, later in the patch in srl_event_listener() why not use the
just-computed/cached GPOINTER_TO_INT (data) in ev->type?

Otherwise I see nothing to object to in this patch.  We understand that this is
addressing a specific case where we have a known problem, but that this more
general solution maybe should be used (in the future) elsewhere.  And at that
point we'll perhaps need another patch...
Comment 3 remus draica 2005-05-13 10:09:21 UTC
event->detail1 and event->detail2 represent the start position and the length of
the deleted text. The new text is obtained by concatenating text before
"detail1" and the text after "detail1 + detail2" (= removing the text between
detail1 and detail1 + detail2). 

>Also, later in the patch in srl_event_listener() why not use the
>just-computed/cached GPOINTER_TO_INT (data) in ev->type?
No reason, probably a copy-paste issue. I agree that event->type should be used.
Comment 4 remus draica 2005-05-17 07:46:07 UTC
Created attachment 46527 [details] [review]
reworked patch
Comment 5 korn 2005-06-25 01:13:20 UTC
Great.  Please apply.
Comment 6 André Klapper 2008-08-22 20:23:13 UTC
There have not been any code commits to Gnopernicus for more than two years, and Gnopernicus has been superseded by Orca in GNOME.
Gnopernicus has been moved to the SVN archives today, and the developers did not respond to any emails.
Hence I'm closing all remaining 25 open bug reports as WONTFIX.