After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 170252 - update epiphany detection, and fix epiphany extension
update epiphany detection, and fix epiphany extension
Status: RESOLVED FIXED
Product: gwget
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: David Sedeño Fernández
David Sedeño Fernández
Depends on:
Blocks:
 
 
Reported: 2005-03-13 23:25 UTC by Christian Persch
Modified: 2005-03-14 21:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (13.58 KB, patch)
2005-03-13 23:26 UTC, Christian Persch
none Details | Review
forgot to cvs add the new extension file (14.26 KB, patch)
2005-03-13 23:29 UTC, Christian Persch
accepted-commit_now Details | Review

Description Christian Persch 2005-03-13 23:25:52 UTC
Attached patch adds detection for Epiphany-1.8, and fixes the epiphany extension
to correctly load/unload, and generally work with 1.6 and 1.8 at all.

The extension itself in the new form will only work with 1.6 or 1.8; if you
really want to preserve compatibility with epiphany 1.4 or even 1.2, I could
modify the patch accordingly. Else I'll remove 1.2 and 1.4 detection and support
from configure.in.

Also I noticed that there are tons of missing .cvsignore files, as well as one
file (po/Makefile.in.in) being in cvs but not beloning there since being
auto-generated by autogen.
Comment 1 Christian Persch 2005-03-13 23:26:22 UTC
Created attachment 38660 [details] [review]
proposed patch

Ok to commit this?
Comment 2 Christian Persch 2005-03-13 23:29:07 UTC
Created attachment 38661 [details] [review]
forgot to cvs add the new extension file
Comment 3 David Sedeño Fernández 2005-03-14 19:48:15 UTC
Comment on attachment 38661 [details] [review]
forgot to cvs add the new extension file

Great!

Commit to cvs please. Don't foget a Changelog entry.
Comment 4 Christian Persch 2005-03-14 21:26:40 UTC
2005-03-14  Christian Persch  <chpe@cvs.gnome.org>

        * configure.in: Detect Epiphany 1.6 and 1.8.

        * epiphany-extension/.cvsignore:
        * epiphany-extension/Makefile.am:
        * epiphany-extension/ephy-gwget-extension.c: (handle_content_cb),
        (ephy_gwget_extension_init), (ephy_gwget_extension_finalize),
        (ephy_gwget_extension_class_init), (ephy_gwget_extension_get_type),
        (ephy_gwget_extension_register_type):
        * epiphany-extension/ephy-gwget-extension.h:
        * epiphany-extension/gwget.xml.in.in:
        * po/POTFILES.in: Update Epiphany extension to work with Epiphany 1.6
and 1.8.
        Add extension description file.