GNOME Bugzilla – Bug 169321
[PATCH] Remove titles from alert dialogs
Last modified: 2005-12-09 12:14:25 UTC
According to the HIG, alert dialogs should not have titles, since a title provides visual clutter and under normal circumstances, duplicates the primary text. The attached patch removes the title from all alert dialogs I could find in nautilus. There are a couple string changes and a lot of string removals. I never found a title that I felt was necessary. Now, obviously I did not test every change, since I can't very well make every error or info dialog appear. So, please, review this carefully to be sure I didn't mess anything up. Other information:
Created attachment 38311 [details] [review] Proposed patch
Adding HIG keyword
If I remember correctly, there is some conflict over this one; the HIG recommendation specifically conflicts with the requirements of the accessibility team. Calum, is this ever going to be resolved?
This is a question that's also just been asked in bug #165132. Since gnopernicus will read the text of an alert whenever the alert is focused, I think the HIG's guidance is acceptable, except for the occasional alert that has to appear in the window list (e.g. an evolution alarm) because it doesn't necessarily belong to a windowed application. I've pinged Bill for a second opinion in that other bug report, so I won't do so again here...
Calum: Your new comment in bug 165132 suggests that there will be put up a draft. Can you already say whether the Nautilus dialogs patched by Michael's patch should have a title or not?
I haven't studied the patch yet, but I think the recommendation will be that alerts that don't appear in the window list or Alt-Tab sequence should preferably still have no title. If there are any alerts that do appear there, they should have a title, but preferably not one that just duplicates the primary text of the alert. I don't yet have a definite idea about exactly what such titles might look like, though. Most likely they should include the action that caused the alert, plus the application name (since the only alerts that would normally appear in the window list are, or could be, the only visible window for that application). So, for example, "Copy Files - File Manager".
Calum: Most of the changes look excellent. The error dialogs really shouldn't have titles. However, I'm not sure on cancellation dialogs, which are shown if an operation takes extraordinarily long. Should these appear in the window list or not?
Calum?
Let me know if you need a screenshot because you don't know what I'm talking about.
Sorry, wasn't paying attention to this one :) No, I don't think cancellation alerts should appear in the window list either, provided they set the window hint that makes the main nautilus window flash in the window list instead. (WM_DEMANDS_ATTENTION, or the other one whose name escapes me at the moment... not sure which one we use.)
I filed another bug including patches at bug 323134 That patch removes the window title property from all the alert dialogs in libeel. That way in new alert dialogs with window titles will not be introduced. And also contains the necessary patch to nautilus to use the modified eel lib.
It seems we finally decided on this. I commited Jaaps patches.