After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 168988 - wrong charset used for i18n in programs not using libgnomeui directly
wrong charset used for i18n in programs not using libgnomeui directly
Status: RESOLVED FIXED
Product: libgnomeui
Classification: Deprecated
Component: file-chooser
2.8.x
Other Linux
: Normal normal
: future
Assigned To: Alexander Larsson
Alexander Larsson
Depends on:
Blocks:
 
 
Reported: 2005-03-02 15:29 UTC by Frederic Crozat
Modified: 2005-05-09 09:29 UTC
See Also:
GNOME target: ---
GNOME version: 2.7/2.8

Attachments
init gettext to use UTF-8 (1.48 KB, patch)
2005-03-02 15:30 UTC, Frederic Crozat 		needs-work Details | Review
better patch, init i18n completely and ifdef bind_textdomain_codeset (1.60 KB, patch)
2005-05-03 08:43 UTC, Frederic Crozat 		committed Details | Review

Description Frederic Crozat 2005-03-02 15:29:02 UTC 
Distribution/Version: Mandrakelinux cooker

bind_textdomain_codeset (GETTEXT_PACKAGE, "UTF-8") is not called in
file-chooser, causing translation to be unreadable in mozilla not using
libgnomeui (like firefox) when locale are not UTF-8.

Attached patch fixes the problem
Comment 1 Frederic Crozat 2005-03-02 15:30:29 UTC 
Created attachment 38157 [details] [review]
init gettext to use UTF-8
Comment 2 Kjartan Maraas 2005-05-02 14:52:21 UTC 
Alex, can this go in?
Comment 3 Alexander Larsson 2005-05-03 08:06:42 UTC 
It needs #ifdef HAVE_BIND_TEXTDOMAIN_CODESET wrappers.

Seems to me that it needs: bindtextdomain (GETTEXT_PACKAGE, GNOMEUILOCALEDIR); too
Comment 4 Frederic Crozat 2005-05-03 08:43:52 UTC 
Created attachment 45967 [details] [review]
better patch, init i18n completely and ifdef bind_textdomain_codeset
Comment 5 Alexander Larsson 2005-05-04 07:06:02 UTC 
Looks good to me.
Comment 6 Frederic Crozat 2005-05-09 09:29:25 UTC 
committed on HEAD and 2.10 branch.