After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 168897 - different text colors in main menu bar selected items
different text colors in main menu bar selected items
Status: RESOLVED DUPLICATE of bug 142417
Product: gnome-panel
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
: 169072 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-03-01 17:04 UTC by Vincent Noel
Modified: 2015-03-24 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (49.87 KB, image/png)
2005-03-01 17:52 UTC, Vincent Noel
Details
Simple GTK+ test (1.51 KB, text/plain)
2005-03-03 21:26 UTC, Vincent Untz
Details
Better test (1.68 KB, text/plain)
2005-03-04 12:01 UTC, Vincent Untz
Details

Description Vincent Noel 2005-03-01 17:04:05 UTC
Selected items in the main menu bar applet have different text colors.
For example, using the "default" gnome theme, the selected "applications" item
has a white text on dark background (which is fine :), but the "Places" and
"Desktop" items have black text on dark background (which is not so fine).

This happens also with industrial, bluecurve, etc, so I don't think it's a theme
issue.

(by the way, there is no bugzilla component for the menu bar applet - should
there be one ?)
Comment 1 Vincent Untz 2005-03-01 17:34:46 UTC
Wow. This is a bit like the old bug #83620.
I'll try to see if I can reproduce. Are you using cvs head for everything?
Comment 2 Vincent Untz 2005-03-01 17:43:40 UTC
I can't reproduce here. Could you attach a screenshot?
(Btw, what theme is "default"? is it simple or traditional?)
Comment 3 Vincent Noel 2005-03-01 17:52:48 UTC
Created attachment 38111 [details]
screenshot

Here is a shot showing selected "Applications" and "Places" menu items.
I am using the clearlooks theme in this shot (...) but it's the same with all
the other themes.

I have gnome-panel, libwnck, gtk+ freshly updated from cvs. When I said the
default theme, I meant Simple.
Comment 4 Vincent Untz 2005-03-01 18:04:57 UTC
Does this happen for other menus in GNOME? Or is it only like this for the menu bar?
I'm updating gnome-themes right now to see if I can reproduce...
Comment 5 Vincent Noel 2005-03-01 18:06:30 UTC
It's specific to the main menu bar applet.
Every other menu works fine.
Comment 6 Vincent Noel 2005-03-01 18:07:27 UTC
It's specific to the main menu bar applet.
Every other menu works fine.

Maybe there's another package I should upgrade ?
Comment 7 Vincent Untz 2005-03-01 18:16:19 UTC
Maybe you should try to upgrade gtk-engines and gnome-themes. And log out...

I don't see this, so I really don't know why this is happening to you. If you're
on IRC, maybe you could try to ask people if they see the same thing...
Comment 8 Vincent Untz 2005-03-03 09:39:48 UTC
*** Bug 169072 has been marked as a duplicate of this bug. ***
Comment 9 Michael Monreal 2005-03-03 10:02:04 UTC
Well sorry for the dupe but I can confirm I have this, too, both in my custom
build on my desktop computer as well as (as of yesterday, after ubuntu updated
their hoary packages) on my laptop.
Comment 10 Michael Monreal 2005-03-03 14:11:58 UTC
I have downgraded my gnome-panel to 2.9.91 (and the corresponding libwnck), with
those versions it *works* so this shouldn't be too hard to figure out. Also,
gnome-themes and/or gtk-engines isn't the cause for the problem. As stated in
169072, this affects all themes which don't use the same prelight color for menu
items as for other widgets (as is the case with both Indubstrial and the new
Clearlooks theme) 
Comment 11 Vincent Noel 2005-03-03 14:21:57 UTC
I've logged out, even rebooted, I still see it.
It's not a big deal for me, but I guess it can be bad if you choose a dark theme
(you won't be able to see the menuitem labels when selected).
Comment 12 Vincent Untz 2005-03-03 14:32:56 UTC
Is this happening for the places/desktop item in the main menu too?

I think this happens because we now build the label (instead of letting GTK
doing this for us). But I don't get why the label is not prelighted.

This is not a blocker, but it'd be nice to fix this for 2.10.1.
Comment 13 Vincent Noel 2005-03-03 14:38:34 UTC
Yes ! It happens also for the places/desktop items in the main menu.
Comment 14 Vincent Untz 2005-03-03 19:08:16 UTC
What's weird is that it works with Glider...
Comment 15 Vincent Untz 2005-03-03 19:18:07 UTC
Works with Crux too and Simple. This /could/ be a theme bug...
Comment 16 Vincent Untz 2005-03-03 19:30:14 UTC
Add this to the gtkrc of the Industrial theme:
widget_class "*MenuItem*" style "industrial-menu"

This works.
Maybe we can do a workaround in the panel...
Comment 17 Vincent Untz 2005-03-03 21:26:41 UTC
Created attachment 38224 [details]
Simple GTK+ test

Here's a more simple test, with only GTK+ things and a GtkMenuItem-derived
widget.

Extract from the GTK+ doc:
*********
Matching against class is a little different. The pattern match is done against
all class names in the widgets class hierarchy (not the layout hierarchy) in
sequence, so the pattern:

class "GtkButton" style "my-style"

will match not just GtkButton widgets, but also GtkToggleButton and
GtkCheckButton widgets, since those classes derive from GtkButton.
*********

Correct me if I'm wrong, but this means that
class "GtkMenuItem" style "menu-style"
sets the style for the GtkMenuItem-derived widget in the above test.

And it seems it doesn't work...
Comment 18 Vincent Untz 2005-03-04 12:01:51 UTC
Created attachment 38240 [details]
Better test

This test has a GtkImageMenuItem too.

What's interesting is that if you remove the line:
widget_class "*.GtkImageMenuItem.*" style "industrial-menu"
from the Industrial gtkrc, the GtkImageMenuItem label is black too.

It really really looks like a GTK+ bug to me.
Comment 19 Vincent Untz 2005-03-04 12:08:36 UTC
This is really bug #142417.

*** This bug has been marked as a duplicate of 142417 ***
Comment 20 Vincent Untz 2005-03-04 12:14:23 UTC
You might want to open bugs against the various themes showing this behaviour.
They should do this:
  widget_class "*MenuItem.*" style "foo"
instead of this:
  widget_class "*.GtkMenuItem.*" style "foo"