After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 168703 - [API] Add gst_index_add_associationv() to gstindex.h
[API] Add gst_index_add_associationv() to gstindex.h
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2005-02-27 23:01 UTC by Torsten Schoenfeld
Modified: 2006-01-18 09:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Adding gst_index_add_associationv() gstindex.h (846 bytes, patch)
2005-02-28 00:23 UTC, Torsten Schoenfeld
committed Details | Review
Updated patch (938 bytes, patch)
2006-01-17 19:03 UTC, Torsten Schoenfeld
none Details | Review

Description Torsten Schoenfeld 2005-02-27 23:01:29 UTC
gst_index_add_associationv() is currently declared non-static in gstindex.c but
is not prototyped in gstindex.h.  Since it's properly documented and necessary
for language bindings, I think gst_index_add_associationv() should be added to
Comment 1 Maciej Katafiasz 2005-02-27 23:34:59 UTC
Indeed. Please provide patch, if you don't mind.
Comment 2 Torsten Schoenfeld 2005-02-28 00:23:33 UTC
Created attachment 38032 [details] [review]
Adding gst_index_add_associationv() gstindex.h

Patch against HEAD of anoncvs.
Comment 3 Ronald Bultje 2005-03-01 10:12:46 UTC
Aren't *v functions usually varargs-based?
Comment 4 David Schleef 2005-03-01 11:10:43 UTC
*_valist() is for va_list-based functions.  *v() is for vector-based, like
g_strdupv() or writev().
Comment 5 Ronald Bultje 2005-03-11 19:48:45 UTC
I misread a few things, sorry. Patch applied.
Comment 6 Torsten Schoenfeld 2005-11-19 14:46:48 UTC
Why was gst_index_add_associationv() removed again in 0.9?
Comment 7 Andy Wingo 2006-01-17 18:18:01 UTC
Probably because 0.9 was branched before this was applied, and didn't get merged up? A mistake most likely. Can you provide a new patch against HEAD?
Comment 8 Torsten Schoenfeld 2006-01-17 19:03:07 UTC
Created attachment 57548 [details] [review]
Updated patch
Comment 9 Andy Wingo 2006-01-18 09:37:15 UTC
In the future two things will help your patches get applied:

1) Make sure they are up to date. You diffed against version 1.17 of that file, but the patch fails to apply to current CVS has version 1.24.

2) Include a ChangeLog entry.

I'll go ahead and manually apply.
Comment 10 Andy Wingo 2006-01-18 09:45:09 UTC
Hm, my bad, must have downloaded the wrong patch ;-)

2006-01-18  Andy Wingo  <>

	* gst/gstindex.h (gst_index_add_associationv): Add to header. The
	symbol was exported before, it appears this was just an oversight.
	Fixes #168703.
	Patch by: Torsten Schoenfeld <kaffeetisch at>

	* gst/gstindex.c (gst_index_add_associationv): Changed int in
	prototype to gint. OK since this prototype was not in the header.