After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 168530 - gtk_accel_map_load: wasteful extra stat call.
gtk_accel_map_load: wasteful extra stat call.
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.10.x
Other All
: Normal minor
: Small fix
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2005-02-25 18:53 UTC by Morten Welinder
Modified: 2013-10-16 01:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove superfluous file test (764 bytes, patch)
2013-10-04 11:51 UTC, Timothy Arceri 		committed Details | Review

Description Morten Welinder 2005-02-25 18:53:56 UTC 
gtk_accel_map_load should not call g_file_test.  It's pointless.  Just because
the file is regular at the time of the test doesn't mean it is regular at
the time of the open.
Comment 1 Timothy Arceri 2013-10-04 11:45:42 UTC 
gtk_accel_map_load still has g_file_test

Updating gtk version to reflect current status
Comment 2 Timothy Arceri 2013-10-04 11:51:59 UTC 
Created attachment 256466 [details] [review]
Remove superfluous file test
Comment 3 Matthias Clasen 2013-10-08 11:38:32 UTC 
Review of attachment 256466 [details] [review]:

sure. not sure its really worth it, but won't do any harm.