GNOME Bugzilla – Bug 168348
[patch]theme-manager must not display "Hidden=true" Icons theme
Last modified: 2005-05-22 16:15:37 UTC
Please describe the problem: When a user selects 'Hicolor' in theme details the desktop icons and many other icons disappear. Steps to reproduce: 1. Open Desktop->Preferences->Theme 2. Click 'Theme Details' and select the 'Icons' tab 3. Select 'Hicolor' from the list. Actual results: The desktop icons disappear Expected results: The desktop icons should change to some (hicolor) icons. Does this happen every time? Yes. Other information:
Mauy be due to /opt/gnome2/share/icons/hicolor/48x48/filesystems is empty. Also, 36x36/filesystems, 64x64/filesystems etc are empty.
Hello AFAIK I think the hicolor theme should be displayed in the list of "Icons", regarding the following lines in the files index.theme : "...This is the default fallback theme used by implementations of the icon theme specification...." and then the theme set to be hidden : Hidden=true (I admit I've already seen this bug for few release, and I not opened a bug. Blame on me)
how is that a control-center bug ?
Re, I made a mistake in my previous comment; replace "should" by "shouldn't". I rename this bug because the real problem is that the theme-manager shouldn't display the icon theme Hicolor. So this is a control-center bug :)
I guess Baptiste is correct. Theme manager is assigned to control center maintainers. "theme-manager control-center-maint@bugzilla.gnome.org" I can confirm that at least the desktop icons of quite some themes are broken/incomplete (Amaranth, HiColor, Industrial...) in Gnome 2.9.91 . *Maybe* some files just were not copied into their respective place as some /share/icons/*/* directories are empty. => I think this really must be tackled before releasing 2.10 . However I am not sure about the Hidden=true option and its meaning. The only reference I found is http://www.gnome.org/learn/admin-guide/latest/ch03s02.html
Baptiste please change the topic to something like "Some icon themes are incomplete" they are handled properly as the missing files are replaced with a standard icon. I am not sure if "Hidden=true" theme.index themes should be hidden in the theme manager list.
according to #bugs share/icons/hicolor/ is a tree and it doesn't have icons. However "Hidden=true" in theme.index should indeed hide the theme in the theme manager list. thus please change topic to "Theme manager details icon list shows themes tagged Hidden=true" or similar.
The description of the key Hidden is: "Whether to hide the theme in a theme selection user interface. This is used for things such as fallback-themes that are not supposed to be visible to the user". http://standards.freedesktop.org/icon-theme-spec/latest/ar01s04.html
Ok, theme should not be listed then. The subdirs of Amaranth, HiColor, Industrial... themes are empty in my garnome build. This is why a fallback happens to standard icon(s) Should it be filed as a sperate themes bug?
Christian, Fill another bug concerning your problem
Created attachment 38143 [details] [review] Patch fixes the problem
If there is a key named 'Hidden' and value is 'true', then don't add the Icon Theme. The 'Icons' tab won't show it in the list.
Patch applies cleanly and works. Raising priority to High to make maintainers aware of it.
*** Bug 160303 has been marked as a duplicate of this bug. ***
Add bug 168977 as a dependency of this one. There are a bunch of a11y themes that should probably be deprecated and hidden, which would clean up the dialog a bit.
patch commited, thanks