After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 168102 - Use PangoFontDescriptions internally for GimpText, instead of serialized strings
Use PangoFontDescriptions internally for GimpText, instead of serialized strings
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: General
git master
Other All
: Normal enhancement
: Future
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2005-02-22 01:43 UTC by Manish Singh
Modified: 2018-05-24 11:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to make font selection more reliable (12.95 KB, patch)
2007-05-26 22:17 UTC, Simon Budig 		needs-work Details | Review

Description Manish Singh 2005-02-22 01:43:02 UTC 
We're doing some contortions to workaround bug #166540, and if bug #168085 is
fixed, some of our font names can potentionally look even uglier.

If we work on PangoFontDescriptions internally, resolving GIMP fonts to pango
fonts is nicely disambiguated. It also gives us the opportunity to pretty print
the names.
Comment 1 Sven Neumann 2005-02-23 10:13:42 UTC 
We would still have to serialize the font somehow and make sure that the same
font is being choosen the next time the text layer in an XCF file is edited.
Comment 2 weskaggs 2006-05-20 23:40:29 UTC 
Bumping to Future since this will not be done for 2.4, but may be addressed as part of text tool improvments for 2.5.
Comment 3 Simon Budig 2007-05-23 01:56:23 UTC 
PangoFontDescriptions apparently are not powerful enough to unambiguously describe the individual PangoFontFaces, see bug #341213.

I guess there is no way around using the FontFaces directly and invent some kind of serializing  :-/
Comment 4 Simon Budig 2007-05-26 22:17:36 UTC 
Created attachment 88870 [details] [review]
Patch to make font selection more reliable

This is a patch that makes the font selection more reliable by (ab)using the fontconfig parts of pango. This makes it possible to use all fonts installed on the system (ok, there might be corner cases I have not yet stumbled upon).

It also is a bit problematic, as people using older versions of the gimp will get a warning message with newer XCFs, but it is not possible to transparently store the fontconfig bits in the "font" property of a GimpText, because that would make the PangoFontDescription generated within older Gimps basically useless.
Comment 5 Simon Budig 2007-05-26 22:21:20 UTC 
Hmm, I just realize that this bug is more about the user visible font names, this does not get adressed with the above patch, although it allows us to generate arbitrarily nice font names without having to care about the serializability for PangoFontDescriptions.
Comment 6 Martin Nordholts 2008-04-25 20:48:47 UTC 
The patch looks sensible to me, should that functionality be needed.
Comment 7 Behdad Esfahbod 2014-08-08 16:47:31 UTC 
Actually I think PangoFontDescriptions might not be adequate.  See bug 733832.
Comment 8 Michael Schumacher 2016-05-31 21:37:45 UTC 
Comment on attachment 88870 [details] [review]
Patch to make font selection more reliable

per comment 7
Comment 9 GNOME Infrastructure Team 2018-05-24 11:26:17 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/130.